Work on TC-IDM-3-2 #35692
Open
Work on TC-IDM-3-2 #35692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved input_msg message argument and made several adjustments accordingly
…moved input_msg message argument and made several adjustments accordingly
…chip#34009) * Remove bugprone-casting-through-void check from .clang-tidy * Add issue number
During tests the following unrelated Exception was raised:
```
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
```
This fixes the issue by removing the extra `self` in the condition.
* [Python] Reset chip error in test commissioner Make sure to reset the chip error in test commissioner on reset. This avoid spurious errors. The Python side reads the error as soon as mTestCommissionerUsed is set, which happens unconditionally. Hence clearing the error is necessary. * [Python] Remove unexpected exception in TC_CGEN_2_4.py With the test commissioner properly resetting the error code the spurious exception is no longer thrown. Remove the exception handling from the test.
…#33975) * Support ICD LIT Device using commissionDevice * Restyled by google-java-format * Restyled by clang-format * Update commission method using Builder * Restyled by whitespace * Restyled by google-java-format * Restyled by gn * Remove warning message in java_controller --------- Co-authored-by: Restyled.io <[email protected]>
…nto issue_322_temp_8
|
PR #35692: Size comparison from 14e75a4 to 659a5fd Full report (14 builds for cc32xx, nrfconnect, nxp, stm32, tizen)
|
|
PR #35692: Size comparison from a76cc9b to 09d7fd3 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Implemented more test steps
Implemented more test steps
|
PR #35692: Size comparison from e7ff441 to e289523 Full report (3 builds for cc32xx, stm32)
|
Fixed a linting issue
|
PR #35692: Size comparison from 10a518b to 2fdc129 Full report (3 builds for cc32xx, stm32)
|
|
PR #35692: Size comparison from 84fb78f to 5318ec6 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
Attempted to fix some linting issues
|
PR #35692: Size comparison from 84fb78f to e3df699 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Implemented step 16 (as a WIP) and refactored for generating writable attributes
Fixed linting issues
Linting fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only first test step is implemented for now but more will be added.
This approach is done for efficiency so that errors with implementing steps can be caught quickly.