Prevent setting up a commissioning session on a suspended controller. #35602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commissioning session setup does not go through MTRDevice or MTRBaseDevice this was not blocked.
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35602: Size comparison from 4f35706 to 7004385 Full report (16 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
kiel-apple
approved these changes
Sep 16, 2024
kiel-apple
reviewed
Sep 16, 2024
Co-authored-by: Kiel Oleson <[email protected]>
woody-apple
approved these changes
Sep 16, 2024
|
PR #35602: Size comparison from 4f35706 to 43c1d99 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast-tracking platform-specific fix with platform owner review. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…project-chip#35602) * Prevent setting up a commissioning session on a suspended controller. Since commissioning session setup does not go through MTRDevice or MTRBaseDevice this was not blocked. * Update src/darwin/Framework/CHIP/MTRDeviceController_Concrete.mm Co-authored-by: Kiel Oleson <[email protected]> --------- Co-authored-by: Kiel Oleson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commissioning session setup does not go through MTRDevice or MTRBaseDevice this was not blocked.