[Silabs] Adds refrigerator application #35433

shgutte · 2024-09-05T19:48:09Z

Adding the new refrigerator application for the silabs

semanticdiff-com · 2024-09-05T19:48:12Z

Review changes with SemanticDiff.

Analyzed 2 of 26 files.

File Information

	Filename	Status
❔	examples/refrigerator-app/silabs/BUILD.gn	Unsupported file format
❔	examples/refrigerator-app/silabs/README.md	Unsupported file format
❔	examples/refrigerator-app/silabs/build_for_wifi_args.gni	Unsupported file format
❔	examples/refrigerator-app/silabs/build_for_wifi_gnfile.gn	Unsupported file format
✔️	examples/refrigerator-app/silabs/build_overrides	Analyzed
❔	examples/refrigerator-app/silabs/openthread.gn	Unsupported file format
❔	examples/refrigerator-app/silabs/openthread.gni	Unsupported file format
✔️	examples/refrigerator-app/silabs/third_party/connectedhomeip	Analyzed
❔	examples/refrigerator-app/silabs/src/AppTask.cpp	Unsupported file format
❔	examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp	Unsupported file format
❔	examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp	Unsupported file format
❔	examples/refrigerator-app/silabs/src/ZclCallbacks.cpp	Unsupported file format
❔	examples/refrigerator-app/silabs/src/refrigerator-and-temperature-controlled-cabinet-mode.cpp	Unsupported file format
❔	examples/refrigerator-app/silabs/include/AppConfig.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/AppEvent.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/AppTask.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/CHIPProjectConfig.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/RefrigeratorIcons.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/RefrigeratorManager.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/RefrigeratorUI.h	Unsupported file format
❔	examples/refrigerator-app/silabs/include/refrigerator-and-temperature-controlled-cabinet-mode.h	Unsupported file format
❔	examples/refrigerator-app/silabs/data_model/BUILD.gn	Unsupported file format
❔	examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter	Unsupported file format
❔	examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap	Unsupported file format
❔	examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter	Unsupported file format
❔	examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap	Unsupported file format

github-actions · 2024-09-05T20:02:46Z

PR #35433: Size comparison from 2bdbc76 to d183a69

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`2bdbc76`	`d183a69`	change	% change
bl602	lighting-app	bl602	FLASH	`1279596`	`1279596`	0	0.0
			RAM	95904	95904	0	0.0
		bl602+mfd	FLASH	`1293706`	`1293706`	0	0.0
			RAM	96048	96048	0	0.0
		bl602+rpc	FLASH	1318560	1318560	0	0.0
			RAM	104328	104328	0	0.0
bl702	lighting-app	bl702	FLASH	944934	944934	0	0.0
			RAM	15209	15209	0	0.0
		bl702+mfd	FLASH	947334	947334	0	0.0
			RAM	15353	15353	0	0.0
		bl702+rpc	FLASH	1040246	1040246	0	0.0
			RAM	24221	24221	0	0.0
		bl706-eth	FLASH	648006	648006	0	0.0
			RAM	25305	25305	0	0.0
		bl706-wifi	FLASH	895420	895420	0	0.0
			RAM	14525	14525	0	0.0
bl702l	lighting-app	bl702l	FLASH	961594	961594	0	0.0
			RAM	16868	16868	0	0.0
		bl702l+mfd	FLASH	964216	964216	0	0.0
			RAM	17012	17012	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	678265	678265	0	0.0
			RAM	78556	78556	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	698117	698117	0	0.0
			RAM	81188	81188	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	698117	698117	0	0.0
			RAM	81188	81188	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	655053	655053	0	0.0
			RAM	73624	73624	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	614601	614601	0	0.0
			RAM	71524	71524	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	634237	634237	0	0.0
			RAM	74076	74076	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	634237	634237	0	0.0
			RAM	74076	74076	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	632625	632625	0	0.0
			RAM	74540	74540	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	652341	652341	0	0.0
			RAM	77092	77092	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	652341	652341	0	0.0
			RAM	77092	77092	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	606917	606917	0	0.0
			RAM	68580	68580	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	626769	626769	0	0.0
			RAM	71212	71212	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	626769	626769	0	0.0
			RAM	71212	71212	0	0.0
efr32	lighting-app	BRD4187C	FLASH	933684	933684	0	0.0
			RAM	135120	135120	0	0.0
	lock-app	BRD4338a	FLASH	740772	740772	0	0.0
			RAM	197184	197184	0	0.0
	window-app	BRD4187C	FLASH	1017448	`1017440`	-8	-0.0
			RAM	127060	127060	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	94128	94128	0	0.0
			FLASH	1538110	1538110	0	0.0
			IRAM	82538	82538	0	0.0
		m5stack	DRAM	115064	115064	0	0.0
			FLASH	`1548558`	`1548558`	0	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4624	4624	0	0.0
			FLASH	2764521	2764521	0	0.0
			RAM	128536	128536	0	0.0
	all-clusters-app	debug	unknown	5408	5408	0	0.0
			FLASH	6075316	6075316	0	0.0
			RAM	510568	510568	0	0.0
	all-clusters-minimal-app	debug	unknown	5304	5304	0	0.0
			FLASH	5399428	5399428	0	0.0
			RAM	240376	240376	0	0.0
	bridge-app	debug	unknown	5288	5288	0	0.0
			FLASH	4733262	4733262	0	0.0
			RAM	217368	217368	0	0.0
	chip-tool	debug	unknown	5832	5832	0	0.0
			FLASH	`1264925`	`1264925`	0	0.0
			RAM	558298	558298	0	0.0
	chip-tool-ipv6only	arm64	unknown	20344	20344	0	0.0
			FLASH	11321460	11321460	0	0.0
			RAM	608328	608328	0	0.0
	fabric-admin	debug	unknown	5664	5664	0	0.0
			FLASH	10956673	10956673	0	0.0
			RAM	557290	557290	0	0.0
	fabric-bridge-app	debug	unknown	4520	4520	0	0.0
			FLASH	`4556096`	`4556096`	0	0.0
			RAM	204016	204016	0	0.0
	lighting-app	debug+rpc+ui	unknown	5936	5936	0	0.0
			FLASH	5680817	5680817	0	0.0
			RAM	228184	228184	0	0.0
	lock-app	debug	unknown	5224	5224	0	0.0
			FLASH	`4787898`	`4787898`	0	0.0
			RAM	203768	203768	0	0.0
	ota-provider-app	debug	unknown	4600	4600	0	0.0
			FLASH	4427468	4427468	0	0.0
			RAM	197752	197752	0	0.0
	ota-requestor-app	debug	unknown	4536	4536	0	0.0
			FLASH	4566022	4566022	0	0.0
			RAM	202288	202288	0	0.0
	shell	debug	unknown	4176	4176	0	0.0
			FLASH	3101757	3101757	0	0.0
			RAM	159200	159200	0	0.0
	thermostat-no-ble	arm64	unknown	9296	9296	0	0.0
			FLASH	4327140	4327140	0	0.0
			RAM	241896	241896	0	0.0
	tv-app	debug	unknown	5504	5504	0	0.0
			FLASH	6014421	6014421	0	0.0
			RAM	583240	583240	0	0.0
	tv-casting-app	debug	unknown	5168	5168	0	0.0
			FLASH	10855533	10855533	0	0.0
			RAM	645768	645768	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	913816	913816	0	0.0
			RAM	142244	142244	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	885552	885552	0	0.0
			RAM	140383	140383	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845204	845204	0	0.0
			RAM	141062	141062	0	0.0
nxp	contact	k32w0+release	FLASH	579500	579500	0	0.0
			RAM	70676	70676	0	0.0
		k32w1+release	FLASH	593328	593328	0	0.0
			RAM	62712	62712	0	0.0
	light	k32w0+release	FLASH	615128	615128	0	0.0
			RAM	70140	70140	0	0.0
		k32w1+release	FLASH	676952	676952	0	0.0
			RAM	47848	47848	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1645932	1645932	0	0.0
			RAM	210944	210944	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1549580	1549580	0	0.0
			RAM	207656	207656	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1468356	1468356	0	0.0
			RAM	200752	200752	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1463644	1463644	0	0.0
			RAM	225064	225064	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	657804	657804	0	0.0
			RAM	105192	105192	0	0.0
	lock-app	qpg6105+debug	FLASH	615960	615960	0	0.0
			RAM	99660	99660	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	481608	481608	0	0.0
			RAM	144740	144740	0	0.0
telink	air-quality-sensor-app	tlsr9528a_retention	FLASH	620506	620506	0	0.0
			RAM	50932	50932	0	0.0
	all-clusters-app	tlsr9118bdk40d	FLASH	685998	685998	0	0.0
			RAM	149576	149576	0	0.0
	all-clusters-minimal-app	tlsr9528a	FLASH	778438	778438	0	0.0
			RAM	110736	110736	0	0.0
	bridge-app	tlsr9258a	FLASH	679498	679498	0	0.0
			RAM	91588	91588	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	622098	622098	0	0.0
			RAM	50972	50972	0	0.0
	light-switch-app-ota-shell-factory-data	tlsr9528a	FLASH	708108	708108	0	0.0
			RAM	74312	74312	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	624298	624298	0	0.0
			RAM	145556	145556	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	810430	810430	0	0.0
			RAM	99480	99480	0	0.0
	lock-app-dfu	tlsr9528a	FLASH	655080	655080	0	0.0
			RAM	67008	67008	0	0.0
	ota-requestor-app	tlsr9258a	FLASH	697364	697364	0	0.0
			RAM	91272	91272	0	0.0
	pump-app-usb	tlsr9518adk80d	FLASH	631806	631806	0	0.0
			RAM	55752	55752	0	0.0
	pump-controller-app	tlsr9518adk80d	FLASH	609054	609054	0	0.0
			RAM	52996	52996	0	0.0
	shell	tlsr9518adk80d	FLASH	466890	466890	0	0.0
			RAM	68660	68660	0	0.0
	smoke_co_alarm-app	tlsr9528a_retention	FLASH	628884	628884	0	0.0
			RAM	52692	52692	0	0.0
	temperature-measurement-app-mars-ota	tlsr9518adk80d	FLASH	653036	653036	0	0.0
			RAM	56632	56632	0	0.0
	thermostat	tlsr9518adk80d	FLASH	635786	635786	0	0.0
			RAM	53400	53400	0	0.0
	window-covering	tlsr9118bdk40d	FLASH	523040	523040	0	0.0
			RAM	98532	98532	0	0.0
tizen	all-clusters-app	arm	unknown	4840	4840	0	0.0
			FLASH	`1721372`	`1721372`	0	0.0
			RAM	89524	89524	0	0.0
	chip-tool-ubsan	arm	unknown	10272	10272	0	0.0
			FLASH	17495182	17495182	0	0.0
			RAM	7593956	7593956	0	0.0

examples/refrigerator-app/silabs/include/RefrigeratorManager.h

examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

examples/refrigerator-app/silabs/README.md

examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp

examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter

lboue · 2024-10-09T16:41:39Z

There is still the ThreeLevelAutoEnum issue/diff in refrigerator-thread-app.matter and refrigerator-wifi-app.matter because of the #35775:

+enum ThreeLevelAutoEnum : enum8 {
+  kLow = 0;
+  kMedium = 1;
+  kHigh = 2;
+  kAutomatic = 3;
+}
+

lboue · 2024-10-10T18:22:38Z

@shgutte Wouldn't OTA clusters be missing from .zap and .matter files?
You can compare with air-quality-sensor:

air-quality-sensor-app.zap

          "name": "OTA Software Update Provider",
          "code": 41,
          "mfgCode": null,
          "define": "OTA_SOFTWARE_UPDATE_PROVIDER_CLUSTER",
          "side": "client",
          "enabled": 1,

air-quality-sensor-app.matter

/** Provides an interface for downloading and applying OTA software updates */
cluster OtaSoftwareUpdateRequestor = 42 {
  revision 1; // NOTE: Default/not specifically set

Not enabled for refrigerator-app/silabs/build_for_wifi_args.gni

chip_enable_ota_requestor = false

But enabled for air-quality-sensor-app/silabs/openthread.gni

Building error:

./scripts/examples/gn_silabs_example.sh ./examples/refrigerator-app/silabs/ ./out/refrigerator-app BRD2703A
...
Done. Made 4287 targets from 336 files in 1621ms
+ '[' false == true ']'
+ ninja -C ./out/refrigerator-app/BRD2703A/
ninja: Entering directory `./out/refrigerator-app/BRD2703A/'
[47/57] ld ./matter-silabs-refrigerator-example.out
FAILED: matter-silabs-refrigerator-example.out
arm-none-eabi-g++ -T../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/examples/platform/silabs/ldscripts/efr32mg24.ld -march=armv8-m.main+dsp -mcpu=cortex-m33 -mabi=aapcs -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mthumb -Og --specs=nosys.specs --specs=nano.specs -Werror -Wl,--fatal-warnings -fdiagnostics-color -Wl,--gc-sections -Wl,--no-warn-rwx-segment -Wl,--wrap=MemoryAlloc -Wl,--wrap=_malloc_r -Wl,--wrap=_realloc_r -Wl,--wrap=_free_r -Wl,--wrap=_calloc_r @./matter-silabs-refrigerator-example.out.rsp -o ./matter-silabs-refrigerator-example.out
/root/connectedhomeip/.environment/cipd/packages/arm/bin/../lib/gcc/arm-none-eabi/12.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/examples/platform/silabs/efr32-common.OTAConfig.cpp.o: in function `chip::DefaultOTARequestorStorage::~DefaultOTARequestorStorage()':

shgutte · 2024-10-11T10:20:26Z

lboue

Hey @lboue
I've added the OTA cluster you can check it

lboue · 2024-10-11T10:54:00Z

Hey @lboue I've added the OTA cluster you can check it

Thanks.

Build is OK for Thread board (BRD2703A) now.
I checked and the OTA cluster is visible at runtime.

shgutte · 2024-10-11T16:07:38Z

Hey @lboue
Can you approve the PR

lboue · 2024-10-11T16:21:05Z

Hey @lboue Can you approve the PR

I am not allowed to merge your PR.

* Added the refrigerator application * Added Implementation of the application * Added RefrigeratorManager * Added changes for the callback and the attribute update * Added changes fot attribute data type * added changes for the refrigrator UI * Updated the wifi args and open thread files * Added changes for refrigerator UI * Added build fixes * Fixed build errors * Added changes for new zap attributes * Added changes for the readme file * Added date and spelling mistake changes * Added changes for spelling mistake * Added updated zap matter file and removed the commented code * Removed the unwanted services from gn file * Added function header * Updated task name and removed the incorrect data * Added callbacks * Modified the datat type and the removed the callback * Removed unwated changes * Added changes for authors * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added changes according to comments * Added the WiFi boards in the board list * Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Fixed the unint32_t alignment for the * Added changes according to comment * Removing warning * Replaced the SILABS_LOGS with CHIPLog * Corrected the application name * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/include/AppTask.h Co-authored-by: Rohan Sahay <[email protected]> * Removed commented code * Updated read me for OTA documentation for SiWx917 * Adds changes for refrigerator modes and callbacks * Added chip logs * Updated the error message * Restyled by whitespace * Restyled by clang-format * Updated refrigerator app matter file * Added the changes related to zap file and the mode supported * Restyled by whitespace * Restyled by clang-format * Added changes for Temperature Controller feature Map * Updated featureMap value for matter file * Removed the temperature level * Removed the startup and on mode from attributes * Setting min and max temperature for the controlled cabinet * Removed the Temperature level attribute from the Temperature controller * Removed the min and max temperature * Removed the attribute update for refrigerator and temperature cluster * Added changes for the zap file * Added restyle changes * Updated matter file * Added OTA requester * Added changes for the attribute * Added changes for the zap --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]>

* [Silabs] Adds refrigerator application (#35433) * Added the refrigerator application * Added Implementation of the application * Added RefrigeratorManager * Added changes for the callback and the attribute update * Added changes fot attribute data type * added changes for the refrigrator UI * Updated the wifi args and open thread files * Added changes for refrigerator UI * Added build fixes * Fixed build errors * Added changes for new zap attributes * Added changes for the readme file * Added date and spelling mistake changes * Added changes for spelling mistake * Added updated zap matter file and removed the commented code * Removed the unwanted services from gn file * Added function header * Updated task name and removed the incorrect data * Added callbacks * Modified the datat type and the removed the callback * Removed unwated changes * Added changes for authors * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added changes according to comments * Added the WiFi boards in the board list * Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Fixed the unint32_t alignment for the * Added changes according to comment * Removing warning * Replaced the SILABS_LOGS with CHIPLog * Corrected the application name * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/include/AppTask.h Co-authored-by: Rohan Sahay <[email protected]> * Removed commented code * Updated read me for OTA documentation for SiWx917 * Adds changes for refrigerator modes and callbacks * Added chip logs * Updated the error message * Restyled by whitespace * Restyled by clang-format * Updated refrigerator app matter file * Added the changes related to zap file and the mode supported * Restyled by whitespace * Restyled by clang-format * Added changes for Temperature Controller feature Map * Updated featureMap value for matter file * Removed the temperature level * Removed the startup and on mode from attributes * Setting min and max temperature for the controlled cabinet * Removed the Temperature level attribute from the Temperature controller * Removed the min and max temperature * Removed the attribute update for refrigerator and temperature cluster * Added changes for the zap file * Added restyle changes * Updated matter file * Added OTA requester * Added changes for the attribute * Added changes for the zap --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]> * Added changes for the zap files --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]>

…5433) * Added the refrigerator application * Added Implementation of the application * Added RefrigeratorManager * Added changes for the callback and the attribute update * Added changes fot attribute data type * added changes for the refrigrator UI * Updated the wifi args and open thread files * Added changes for refrigerator UI * Added build fixes * Fixed build errors * Added changes for new zap attributes * Added changes for the readme file * Added date and spelling mistake changes * Added changes for spelling mistake * Added updated zap matter file and removed the commented code * Removed the unwanted services from gn file * Added function header * Updated task name and removed the incorrect data * Added callbacks * Modified the datat type and the removed the callback * Removed unwated changes * Added changes for authors * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added changes according to comments * Added the WiFi boards in the board list * Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Fixed the unint32_t alignment for the * Added changes according to comment * Removing warning * Replaced the SILABS_LOGS with CHIPLog * Corrected the application name * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/include/AppTask.h Co-authored-by: Rohan Sahay <[email protected]> * Removed commented code * Updated read me for OTA documentation for SiWx917 * Adds changes for refrigerator modes and callbacks * Added chip logs * Updated the error message * Restyled by whitespace * Restyled by clang-format * Updated refrigerator app matter file * Added the changes related to zap file and the mode supported * Restyled by whitespace * Restyled by clang-format * Added changes for Temperature Controller feature Map * Updated featureMap value for matter file * Removed the temperature level * Removed the startup and on mode from attributes * Setting min and max temperature for the controlled cabinet * Removed the Temperature level attribute from the Temperature controller * Removed the min and max temperature * Removed the attribute update for refrigerator and temperature cluster * Added changes for the zap file * Added restyle changes * Updated matter file * Added OTA requester * Added changes for the attribute * Added changes for the zap --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]> (cherry picked from commit f59864b)

…t-chip#35433)" This reverts commit ccf8859. Signed-off-by: Gatien Chapon <[email protected]>

* Added the refrigerator application * Added Implementation of the application * Added RefrigeratorManager * Added changes for the callback and the attribute update * Added changes fot attribute data type * added changes for the refrigrator UI * Updated the wifi args and open thread files * Added changes for refrigerator UI * Added build fixes * Fixed build errors * Added changes for new zap attributes * Added changes for the readme file * Added date and spelling mistake changes * Added changes for spelling mistake * Added updated zap matter file and removed the commented code * Removed the unwanted services from gn file * Added function header * Updated task name and removed the incorrect data * Added callbacks * Modified the datat type and the removed the callback * Removed unwated changes * Added changes for authors * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added changes according to comments * Added the WiFi boards in the board list * Update examples/refrigerator-app/silabs/include/CHIPProjectConfig.h Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Fixed the unint32_t alignment for the * Added changes according to comment * Removing warning * Replaced the SILABS_LOGS with CHIPLog * Corrected the application name * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/README.md Co-authored-by: Junior Martinez <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorUI.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/AppTask.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Co-authored-by: Rohan Sahay <[email protected]> * Update examples/refrigerator-app/silabs/include/AppTask.h Co-authored-by: Rohan Sahay <[email protected]> * Removed commented code * Updated read me for OTA documentation for SiWx917 * Adds changes for refrigerator modes and callbacks * Added chip logs * Updated the error message * Restyled by whitespace * Restyled by clang-format * Updated refrigerator app matter file * Added the changes related to zap file and the mode supported * Restyled by whitespace * Restyled by clang-format * Added changes for Temperature Controller feature Map * Updated featureMap value for matter file * Removed the temperature level * Removed the startup and on mode from attributes * Setting min and max temperature for the controlled cabinet * Removed the Temperature level attribute from the Temperature controller * Removed the min and max temperature * Removed the attribute update for refrigerator and temperature cluster * Added changes for the zap file * Added restyle changes * Updated matter file * Added OTA requester * Added changes for the attribute * Added changes for the zap --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]>

github-actions bot added the examples label Sep 5, 2024

lboue reviewed Sep 5, 2024

View reviewed changes

examples/refrigerator-app/silabs/include/RefrigeratorManager.h Outdated Show resolved Hide resolved

lboue reviewed Sep 9, 2024

View reviewed changes

examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Outdated Show resolved Hide resolved

senthilku reviewed Sep 9, 2024

View reviewed changes

examples/refrigerator-app/silabs/README.md Outdated Show resolved Hide resolved

github-actions bot added documentation Improvements or additions to documentation tools scripts integrations transport setup payload platform darwin esp32 nrf connect zephyr lib controller app config vscode github workflows gn telink tests support core test driver labels Sep 10, 2024

tcarmelveilleux reviewed Oct 2, 2024

View reviewed changes

examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Oct 2, 2024

View reviewed changes

examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter Outdated Show resolved Hide resolved

shgutte added 7 commits October 3, 2024 12:10

Removed the startup and on mode from attributes

b0706ca

Setting min and max temperature for the controlled cabinet

3b4de3e

Removed the Temperature level attribute from the Temperature controller

a9b101a

Removed the min and max temperature

4e86d8d

Removed the attribute update for refrigerator and temperature cluster

ece4c4e

Added changes for the zap file

cf95594

Added restyle changes

656d005

tcarmelveilleux approved these changes Oct 10, 2024

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 10, 2024

Updated matter file

b09507b

shgutte added 2 commits October 11, 2024 12:32

Added OTA requester

52f5dfc

Added changes for the attribute

d11e310

Added changes for the zap

b8e0299

jmartinez-silabs merged commit f59864b into project-chip:master Oct 11, 2024
72 checks passed

shgutte mentioned this pull request Oct 18, 2024

[Cherry-pick] Adds refrigerator application (#35433) #36138

Merged

marius-alex-tache pushed a commit to NXP/matter that referenced this pull request Nov 14, 2024

Revert "[nxp fromtree] [Silabs] Adds refrigerator application (projec…

239893e

…t-chip#35433)" This reverts commit ccf8859. Signed-off-by: Gatien Chapon <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Silabs] Adds refrigerator application #35433

[Silabs] Adds refrigerator application #35433

shgutte commented Sep 5, 2024

semanticdiff-com bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

lboue commented Oct 9, 2024 •

edited

Loading

lboue commented Oct 10, 2024 •

edited

Loading

shgutte commented Oct 11, 2024

lboue commented Oct 11, 2024 •

edited

Loading

shgutte commented Oct 11, 2024

lboue commented Oct 11, 2024

[Silabs] Adds refrigerator application #35433

[Silabs] Adds refrigerator application #35433

Conversation

shgutte commented Sep 5, 2024

semanticdiff-com bot commented Sep 5, 2024 • edited Loading

github-actions bot commented Sep 5, 2024 • edited Loading

lboue commented Oct 9, 2024 • edited Loading

lboue commented Oct 10, 2024 • edited Loading

shgutte commented Oct 11, 2024

lboue commented Oct 11, 2024 • edited Loading

shgutte commented Oct 11, 2024

lboue commented Oct 11, 2024

semanticdiff-com bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

lboue commented Oct 9, 2024 •

edited

Loading

lboue commented Oct 10, 2024 •

edited

Loading

lboue commented Oct 11, 2024 •

edited

Loading