[Silabs] MDNS and matter packet filter on WiFi Devices #34335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
|
PR #34335: Size comparison from ff6863e to 0d673da Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34335: Size comparison from edf1f65 to f84980e Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34335: Size comparison from 4e15283 to dcafdcb Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34335: Size comparison from 4269ff5 to ed212d9 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Comment on lines
+16
to
+22
| for (size_t i = 0; i < hostName.size(); ++i) | ||
| { | ||
| char ch_data = *(hostName.data()); |
There was a problem hiding this comment.
Is there a reason not to do:
Suggested change
| for (size_t i = 0; i < hostName.size(); ++i) | |
| { | |
| char ch_data = *(hostName.data()); | |
| for (char ch_data : hostName) | |
| { |
?
There was a problem hiding this comment.
notice the span interation is not working, will have a check once
There was a problem hiding this comment.
I don't understand this comment...
chirag-silabs
force-pushed
the
bugfix/mdns_filter_matter_layer
branch
from
bfd2a0b to
383b9d1
Compare
|
PR #34335: Size comparison from 45a75ba to 6235747 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Comment on lines
+16
to
+22
| for (size_t i = 0; i < hostName.size(); ++i) | ||
| { | ||
| char ch_data = *(hostName.data()); |
There was a problem hiding this comment.
I don't understand this comment...
chirag-silabs
force-pushed
the
bugfix/mdns_filter_matter_layer
branch
from
6235747 to
a99409b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the filter on the MDNS and matter packet filter for the wifi device when device is sleepy.
Tested on SiWx917 SoC