Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1 cherrypick: Fix handling of non-permitted messages in ExchangeContext #33292

Merged
merged 1 commit into from
May 3, 2024
Merged

1.1 cherrypick: Fix handling of non-permitted messages in ExchangeContext #33292

merged 1 commit into from
May 3, 2024

Conversation

andy31415
Copy link
Contributor

This cherrypicks #33148 into 1.1

They should not count as responses, since we don't notify our delegate about them.

@bzbarsky-apple @andreilitvin
Fix handling of non-permitted messages in ExchangeContext. (project-c…
77e4263 
…hip#33148)

They should not count as responses, since we don't notify our delegate about
them.
@andy31415 andy31415 merged commit 3c808ab into project-chip:v1.1-branch May 3, 2024
32 of 52 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

PR #33292: Size comparison from 798deb7 to 77e4263

Increases (6 builds for cc32xx, cyw30739, psoc6)
platform target config section 798deb7 77e4263 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 963768 963781 13 0.0
.debug_loclists 1496949 1496958 9 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 528667 528675 8 0.0
.app_xip_area 416165 416173 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_abbrev 1301237 1301250 13 0.0
.debug_loclists 2029962 2029971 9 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_abbrev 1286252 1286265 13 0.0
.debug_loclists 2019600 2019609 9 0.0
light cy8ckit_062s2_43012 .debug_abbrev 1117878 1117891 13 0.0
.debug_loclists 1851738 1851747 9 0.0
lock cy8ckit_062s2_43012 .debug_abbrev 1116940 1116953 13 0.0
.debug_loclists 1865132 1865141 9 0.0
Decreases (7 builds for cc32xx, cyw30739, nrfconnect, psoc6)
platform target config section 798deb7 77e4263 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19572503 19572501 -2 -0.0
.debug_line 2676157 2676061 -96 -0.0
cyw30739 ota-requestor cyw930739m2evb_01 (read/write) 566155 566147 -8 -0.0
.app_xip_area 459701 459693 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1123616 1123600 -16 -0.0
text 778140 778136 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27130505 27130504 -1 -0.0
.debug_line 3779973 3779873 -100 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26644131 26644129 -2 -0.0
.debug_line 3787180 3787080 -100 -0.0
light cy8ckit_062s2_43012 (read/write) 1574412 1574396 -16 -0.0
.debug_line 3349834 3349734 -100 -0.0
.text 1380364 1380348 -16 -0.0
lock cy8ckit_062s2_43012 (read/write) 1630908 1630892 -16 -0.0
.debug_line 3346210 3346110 -100 -0.0
.text 1409068 1409052 -16 -0.0
Full report (17 builds for cc32xx, cyw30739, k32w, nrfconnect, psoc6, qpg)
platform target config section 798deb7 77e4263 change % change
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606594 606594 0 0.0
(read/write) 204172 204172 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197584 197584 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 963768 963781 13 0.0
.debug_aranges 101824 101824 0 0.0
.debug_frame 343616 343616 0 0.0
.debug_info 19572503 19572501 -2 -0.0
.debug_line 2676157 2676061 -96 -0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1496949 1496958 9 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94822 94822 0 0.0
.debug_str 3116925 3116925 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104498 104498 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 493604 493604 0 0.0
.symtab 290416 290416 0 0.0
.text 499972 499972 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 523995 523995 0 0.0
.app_xip_area 416789 416789 0 0.0
.bss 62192 62192 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528667 528675 8 0.0
.app_xip_area 416165 416173 8 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566155 566147 -8 -0.0
.app_xip_area 459701 459693 -8 -0.0
.bss 61480 61480 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530547 530547 0 0.0
.app_xip_area 421541 421541 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read only) 584404 584404 0 0.0
(read/write) 90100 90100 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 583868 583868 0 0.0
light k32w0+release (read only) 583220 583220 0 0.0
(read/write) 89748 89748 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582684 582684 0 0.0
lock k32w0+release (read only) 555724 555724 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555188 555188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1178396 1178396 0 0.0
bss 155601 155601 0 0.0
rodata 133180 133180 0 0.0
text 808888 808888 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1438184 1438184 0 0.0
bss 135341 135341 0 0.0
rodata 229112 229112 0 0.0
text 779700 779700 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123616 1123600 -16 -0.0
bss 154757 154757 0 0.0
rodata 109984 109984 0 0.0
text 778140 778136 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 838584 838584 0 0.0
(read/write) 1712644 1712644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192204 192204 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1301237 1301250 13 0.0
.debug_aranges 129232 129232 0 0.0
.debug_frame 428404 428404 0 0.0
.debug_info 27130505 27130504 -1 -0.0
.debug_line 3779973 3779873 -100 -0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2029962 2029971 9 0.0
.debug_rnglists 128772 128772 0 0.0
.debug_str 3629999 3629999 0 0.0
.heap 838584 838584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 730959 730959 0 0.0
.symtab 471104 471104 0 0.0
.text 1509500 1509500 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 839384 839384 0 0.0
(read/write) 1652564 1652564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191404 191404 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1286252 1286265 13 0.0
.debug_aranges 128376 128376 0 0.0
.debug_frame 430460 430460 0 0.0
.debug_info 26644131 26644129 -2 -0.0
.debug_line 3787180 3787080 -100 -0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2019600 2019609 9 0.0
.debug_rnglists 127657 127657 0 0.0
.debug_str 3616475 3616475 0 0.0
.heap 839384 839384 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 685386 685386 0 0.0
.symtab 454960 454960 0 0.0
.text 1450220 1450220 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 847680 847680 0 0.0
(read/write) 1574412 1574396 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 183276 183276 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1117878 1117891 13 0.0
.debug_aranges 118496 118496 0 0.0
.debug_frame 393592 393592 0 0.0
.debug_info 22198094 22198094 0 0.0
.debug_line 3349834 3349734 -100 -0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1851738 1851747 9 0.0
.debug_rnglists 117262 117262 0 0.0
.debug_str 3422891 3422891 0 0.0
.heap 847680 847680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 601439 601439 0 0.0
.symtab 417408 417408 0 0.0
.text 1380364 1380348 -16 -0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 819888 819888 0 0.0
(read/write) 1630908 1630892 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211060 211060 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1116940 1116953 13 0.0
.debug_aranges 119008 119008 0 0.0
.debug_frame 395712 395712 0 0.0
.debug_info 22376259 22376259 0 0.0
.debug_line 3346210 3346110 -100 -0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1865132 1865141 9 0.0
.debug_rnglists 117724 117724 0 0.0
.debug_str 3437869 3437869 0 0.0
.heap 819888 819888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 605440 605440 0 0.0
.symtab 419712 419712 0 0.0
.text 1409068 1409052 -16 -0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1168096 1168096 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 615196 615196 0 0.0
lock-app qpg6105+debug (read/write) 1137472 1137472 0 0.0
.bss 94784 94784 0 0.0
.data 852 852 0 0.0
.text 584568 584568 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @bzbarsky-apple