-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for arm64 build failure when bluetooth enabled on linux platform #32817
Merged
mergify
merged 3 commits into
project-chip:master
from
sabollim-silabs:bugfix/fix-arm64-build-failure-with-bluetooth-in-linux-platofrm
Oct 14, 2024
Merged
Fix for arm64 build failure when bluetooth enabled on linux platform #32817
mergify
merged 3 commits into
project-chip:master
from
sabollim-silabs:bugfix/fix-arm64-build-failure-with-bluetooth-in-linux-platofrm
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32817: Size comparison from 3099269 to 125c300 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 4, 2024
Old PR in draft form. Closing as stale. |
Reopening, we should just make this change. |
andy31415
approved these changes
Oct 11, 2024
PR #32817: Size comparison from 1988399 to 125c300 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 14, 2024
I've added the same fix for Tizen platform. |
PR #32817: Size comparison from dcb4444 to 3a41a90 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#32817) * fix arm64 build failure when bluetooth enabled on linux platform * Use C++ keyword for getting type --------- Co-authored-by: sabollim <[email protected]> Co-authored-by: Arkadiusz Bokowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem: In the platform/Linux code for bluetooth, we are using "typeof" in ConnectDevice function. which throws an error ("typeof not found") for the arm64 build.
Description of Fix:
Changed the "typeof" to "decltype" which is a valid C++ Standard keyword.
Testing Done:
Locally tested, arm64 build successful