Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make builder unit tests pass in vscode image. #32815

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Make builder unit tests pass in vscode image. #32815

merged 1 commit into from
Apr 3, 2024

Conversation

andy31415
Copy link
Contributor

vscode image defines more environment variables. Provide overrides for these variables in unit tests, so that they pass for vscode image as well and they do not get picked up from the system env.

@andreilitvin
Make builder unit tests pass in vscode image.
d7c7f19 
vscode image defines more environment variables. Provide
overrides for these variables in unit tests, so that they pass
for vscode image as well and they do not get picked up
from the system env.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

PR #32815: Size comparison from bdde1cd to d7c7f19

Decreases (1 build for efr32)
platform target config section bdde1cd d7c7f19 change % change
efr32 lock-app BRD4338a (read/write) 958296 958288 -8 -0.0
.text 698540 698532 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section bdde1cd d7c7f19 change % change
bl602 lighting-app bl602 (read/write) 1438514 1438514 0 0.0
.bss 85360 85360 0 0.0
.data 9504 9504 0 0.0
.rodata 158524 158524 0 0.0
.text 1104476 1104476 0 0.0
bl602+mfd (read/write) 1452938 1452938 0 0.0
.bss 85520 85520 0 0.0
.data 9480 9480 0 0.0
.rodata 157484 157484 0 0.0
.text 1119794 1119794 0 0.0
bl602+rpc (read/write) 1486162 1486162 0 0.0
.bss 93392 93392 0 0.0
.data 9880 9880 0 0.0
.rodata 166092 166092 0 0.0
.text 1136122 1136122 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1203211 1203211 0 0.0
.bss 11133 11133 0 0.0
.data 3688 3688 0 0.0
.rodata 107876 107876 0 0.0
.text 973640 973640 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1214283 1214283 0 0.0
.bss 11309 11309 0 0.0
.data 3664 3664 0 0.0
.rodata 106816 106816 0 0.0
.text 985650 985650 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1294959 1294959 0 0.0
.bss 19613 19613 0 0.0
.data 4224 4224 0 0.0
.rodata 123248 123248 0 0.0
.text 1048604 1048604 0 0.0
bl706-eth (read/write) 1020649 1020649 0 0.0
.bss 23708 23708 0 0.0
.data 3264 3264 0 0.0
.rodata 101208 101208 0 0.0
.text 764492 764492 0 0.0
bl706-wifi (read/write) 1255294 1255294 0 0.0
.bss 10577 10577 0 0.0
.data 3696 3696 0 0.0
.rodata 122208 122208 0 0.0
.text 996382 996382 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1172800 1172800 0 0.0
.bss 16328 16328 0 0.0
.data 5048 5048 0 0.0
.rodata 101880 101880 0 0.0
.text 966750 966750 0 0.0
bl702l+mfd (read/write) 1184716 1184716 0 0.0
.bss 16504 16504 0 0.0
.data 5032 5032 0 0.0
.rodata 100820 100820 0 0.0
.text 979072 979072 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 774852 774852 0 0.0
(read/write) 168648 168648 0 0.0
.bss 90636 90636 0 0.0
.data 3568 3568 0 0.0
.rodata 82148 82148 0 0.0
.text 692436 692436 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 791244 791244 0 0.0
(read/write) 178896 178896 0 0.0
.bss 100884 100884 0 0.0
.data 3568 3568 0 0.0
.rodata 76332 76332 0 0.0
.text 714644 714644 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779916 779916 0 0.0
(read/write) 173336 173336 0 0.0
.bss 95324 95324 0 0.0
.data 3568 3568 0 0.0
.rodata 103084 103084 0 0.0
.text 676564 676564 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 732116 732116 0 0.0
(read/write) 167616 167616 0 0.0
.bss 89368 89368 0 0.0
.data 3560 3560 0 0.0
.rodata 77812 77812 0 0.0
.text 654036 654036 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 717716 717716 0 0.0
(read/write) 167824 167824 0 0.0
.bss 89592 89592 0 0.0
.data 3552 3552 0 0.0
.rodata 73588 73588 0 0.0
.text 643860 643860 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 584362 584362 0 0.0
(read/write) 208000 208000 0 0.0
.bss 201228 201228 0 0.0
.data 1648 1648 0 0.0
.rodata 86938 86938 0 0.0
.text 495300 495300 0 0.0
lock CC3235SF_LAUNCHXL (read only) 629610 629610 0 0.0
(read/write) 208344 208344 0 0.0
.bss 201720 201720 0 0.0
.data 1504 1504 0 0.0
.rodata 107386 107386 0 0.0
.text 520100 520100 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 568043 568043 0 0.0
.app_xip_area 458037 458037 0 0.0
.bss 64832 64832 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 550683 550683 0 0.0
.app_xip_area 435917 435917 0 0.0
.bss 69584 69584 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570987 570987 0 0.0
.app_xip_area 462485 462485 0 0.0
.bss 63368 63368 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 563779 563779 0 0.0
.app_xip_area 451997 451997 0 0.0
.bss 66568 66568 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1111864 1111864 0 0.0
.bss 195184 195184 0 0.0
.data 3424 3424 0 0.0
.text 913236 913236 0 0.0
lock-app BRD4338a (read/write) 958296 958288 -8 -0.0
.bss 210196 210196 0 0.0
.data 30192 30192 0 0.0
.text 698540 698532 -8 -0.0
window-app BRD4187C (read/write) 1159192 1159192 0 0.0
.bss 167592 167592 0 0.0
.data 3336 3336 0 0.0
.text 988244 988244 0 0.0
esp32 all-clusters-app c3devkit (read only) 1212052 1212052 0 0.0
(read/write) 1749856 1749856 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252368 252368 0 0.0
.flash.text 1212052 1212052 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253551 1253551 0 0.0
(read/write) 535928 535928 0 0.0
.dram0.bss 81008 81008 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 283820 283820 0 0.0
.flash.text 1247387 1247387 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605624 605624 0 0.0
(read/write) 79512 79512 0 0.0
.bss 67340 67340 0 0.0
.data 2188 2188 0 0.0
.text 605088 605088 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 700492 700492 0 0.0
.bss 71156 71156 0 0.0
.data 2856 2856 0 0.0
.text 587096 587096 0 0.0
light k32w0+release (read only) 607584 607584 0 0.0
(read/write) 79372 79372 0 0.0
.bss 67196 67196 0 0.0
.data 2192 2192 0 0.0
.text 607048 607048 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 792032 792032 0 0.0
.bss 80636 80636 0 0.0
.data 2056 2056 0 0.0
.text 669976 669976 0 0.0
linux air-purifier-app debug (read only) 2638477 2638477 0 0.0
(read/write) 129272 129272 0 0.0
.bss 46608 46608 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 74472 74472 0 0.0
.dynamic 608 608 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 185072 185072 0 0.0
.text 2275621 2275621 0 0.0
all-clusters-app debug (read only) 5944961 5944961 0 0.0
(read/write) 480744 480744 0 0.0
.bss 134912 134912 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 333864 333864 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1408 1408 0 0.0
.rodata 349840 349840 0 0.0
.text 5161539 5161539 0 0.0
all-clusters-minimal-app debug (read only) 5225377 5225377 0 0.0
(read/write) 236696 236696 0 0.0
.bss 127744 127744 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 97448 97448 0 0.0
.dynamic 624 624 0 0.0
.got 5256 5256 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 288874 288874 0 0.0
.text 4701587 4701587 0 0.0
bridge-app debug (read only) 4619777 4619777 0 0.0
(read/write) 217576 217576 0 0.0
.bss 118272 118272 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86368 86368 0 0.0
.dynamic 624 624 0 0.0
.got 5224 5224 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 229482 229482 0 0.0
.text 4169795 4169795 0 0.0
chip-tool debug (read only) 12074817 12074817 0 0.0
(read/write) 522240 522240 0 0.0
.bss 94488 94488 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 415408 415408 0 0.0
.dynamic 624 624 0 0.0
.got 5744 5744 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 450233 450233 0 0.0
.text 10917427 10917427 0 0.0
chip-tool-ipv6only arm64 (read only) 11394532 11394532 0 0.0
(read/write) 588384 588384 0 0.0
.bss 103608 103608 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455320 455320 0 0.0
.dynamic 512 512 0 0.0
.got 17024 17024 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 355604 355604 0 0.0
.text 10158856 10158856 0 0.0
lighting-app debug+rpc+ui (read only) 5543241 5543241 0 0.0
(read/write) 226336 226336 0 0.0
.bss 119208 119208 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 94752 94752 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 354452 354452 0 0.0
.text 4941907 4941907 0 0.0
lock-app debug (read only) 4687121 4687121 0 0.0
(read/write) 205160 205160 0 0.0
.bss 113696 113696 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 80616 80616 0 0.0
.dynamic 624 624 0 0.0
.got 5176 5176 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 255434 255434 0 0.0
.text 4219827 4219827 0 0.0
ota-provider-app debug (read only) 4301313 4301313 0 0.0
(read/write) 193432 193432 0 0.0
.bss 113312 113312 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 208490 208490 0 0.0
.text 3899635 3899635 0 0.0
ota-requestor-app debug (read only) 4430753 4430753 0 0.0
(read/write) 197800 197800 0 0.0
.bss 114208 114208 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 72944 72944 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 214602 214602 0 0.0
.text 4018419 4018419 0 0.0
shell debug (read only) 2910953 2910953 0 0.0
(read/write) 156144 156144 0 0.0
.bss 62416 62416 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 86544 86544 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 185536 185536 0 0.0
.text 2551938 2551938 0 0.0
thermostat-no-ble arm64 (read only) 4419604 4419604 0 0.0
(read/write) 243328 243328 0 0.0
.bss 121832 121832 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 103680 103680 0 0.0
.dynamic 512 512 0 0.0
.got 8624 8624 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 159788 159788 0 0.0
.text 3924952 3924952 0 0.0
tv-app debug (read only) 5755081 5755081 0 0.0
(read/write) 352536 352536 0 0.0
.bss 244080 244080 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 94616 94616 0 0.0
.dynamic 624 624 0 0.0
.got 5472 5472 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 292458 292458 0 0.0
.text 5220451 5220451 0 0.0
tv-casting-app debug (read only) 9885193 9885193 0 0.0
(read/write) 340120 340120 0 0.0
.bss 155920 155920 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174304 174304 0 0.0
.dynamic 624 624 0 0.0
.got 5048 5048 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 382840 382840 0 0.0
.text 9036723 9036723 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2533232 2533232 0 0.0
.bss 220480 220480 0 0.0
.data 5216 5216 0 0.0
.text 1495916 1495916 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1063128 1063128 0 0.0
bss 133115 133115 0 0.0
rodata 102680 102680 0 0.0
text 780120 780120 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1224412 1224412 0 0.0
bss 127171 127171 0 0.0
rodata 151168 151168 0 0.0
text 796052 796052 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1010656 1010656 0 0.0
bss 131973 131973 0 0.0
rodata 89944 89944 0 0.0
text 741408 741408 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834416 834416 0 0.0
(read/write) 1797940 1797940 0 0.0
.bss 196244 196244 0 0.0
.data 2680 2680 0 0.0
.text 1590628 1590628 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837568 837568 0 0.0
(read/write) 1719876 1719876 0 0.0
.bss 193124 193124 0 0.0
.data 2648 2648 0 0.0
.text 1515716 1515716 0 0.0
light cy8ckit_062s2_43012 (read only) 844296 844296 0 0.0
(read/write) 1638964 1638964 0 0.0
.bss 186588 186588 0 0.0
.data 2456 2456 0 0.0
.text 1441532 1441532 0 0.0
lock cy8ckit_062s2_43012 (read only) 817136 817136 0 0.0
(read/write) 1668572 1668572 0 0.0
.bss 213748 213748 0 0.0
.data 2456 2456 0 0.0
.text 1443980 1443980 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130560 1130560 0 0.0
.bss 102488 102488 0 0.0
.data 836 836 0 0.0
.text 642944 642944 0 0.0
lock-app qpg6105+debug (read/write) 1090536 1090536 0 0.0
.bss 97232 97232 0 0.0
.data 856 856 0 0.0
.text 602916 602916 0 0.0
stm32 light STM32WB5MM-DK (read/write) 601749 601749 0 0.0
.bss 128352 128352 0 0.0
.data 676 676 0 0.0
.rodata 79796 79796 0 0.0
.text 383192 383192 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824514 824514 0 0.0
bss 49692 49692 0 0.0
text 617194 617194 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1093408 1093408 0 0.0
bss 101812 101812 0 0.0
text 794354 794354 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050832 1050832 0 0.0
bss 110108 110108 0 0.0
text 765636 765636 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 911552 911552 0 0.0
bss 93148 93148 0 0.0
text 653110 653110 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826130 826130 0 0.0
bss 49732 49732 0 0.0
text 618884 618884 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 929708 929708 0 0.0
bss 77472 77472 0 0.0
text 697582 697582 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1074724 1074724 0 0.0
bss 100220 100220 0 0.0
text 778504 778504 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 904240 904240 0 0.0
bss 69204 69204 0 0.0
text 654284 654284 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 930524 930524 0 0.0
bss 92720 92720 0 0.0
text 672198 672198 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828870 828870 0 0.0
bss 49840 49840 0 0.0
text 621956 621956 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 792444 792444 0 0.0
bss 56040 56040 0 0.0
text 592630 592630 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675848 675848 0 0.0
bss 73404 73404 0 0.0
text 461618 461618 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833674 833674 0 0.0
bss 51372 51372 0 0.0
text 625254 625254 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 852405 852405 0 0.0
bss 59516 59516 0 0.0
text 637340 637340 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 818100 818100 0 0.0
bss 56336 56336 0 0.0
text 612314 612314 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 836184 836184 0 0.0
bss 68112 68112 0 0.0
text 627562 627562 0 0.0

@mergify mergify bot merged commit c172e30 into project-chip:master Apr 3, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@tehampson tehampson tehampson approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tehampson @Damian-Nordic @andreilitvin