-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DiagnosticLogs] Allow TransferFileDesignator or size 0 #32267
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:DiagnosticLogs_Followup_4
Feb 23, 2024
Merged
[DiagnosticLogs] Allow TransferFileDesignator or size 0 #32267
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:DiagnosticLogs_Followup_4
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 22, 2024 17:27
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 22, 2024 17:27
yunhanw-google
approved these changes
Feb 22, 2024
PR #32267: Size comparison from 93da263 to aa8a37b Decreases (10 builds for cc32xx, efr32, esp32, psoc6, qpg)
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, stm32)
|
bzbarsky-apple
approved these changes
Feb 22, 2024
vivien-apple
force-pushed
the
DiagnosticLogs_Followup_4
branch
from
February 23, 2024 08:12
aa8a37b
to
6ea0be8
Compare
PR #32267: Size comparison from 233c177 to 6ea0be8 Increases (6 builds for linux)
Decreases (19 builds for cc32xx, efr32, esp32, linux, nrfconnect, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seems like 32207 was wrong.