-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] StayActiveRequest #32247
Merged
yunhanw-google
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd-stay-active
Feb 26, 2024
Merged
[ICD] StayActiveRequest #32247
yunhanw-google
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd-stay-active
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
system
darwin
controller
app
tests
icd
Intermittently Connected Devices
labels
Feb 21, 2024
lpbeliveau-silabs
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Feb 21, 2024
Added skip backwards compatibility as the command was previously unsupported. |
lpbeliveau-silabs
force-pushed
the
feature/icd-stay-active
branch
from
February 21, 2024 20:11
130bdc3
to
67984aa
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
February 21, 2024 20:12
PR #32247: Size comparison from 9aeff06 to 67984aa Increases (4 builds for nrfconnect, stm32)
Full report (4 builds for nrfconnect, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/icd-stay-active
branch
from
February 21, 2024 20:34
67984aa
to
ba60af4
Compare
PR #32247: Size comparison from 9aeff06 to ba60af4 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (4 builds for bl702l, efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Feb 21, 2024
src/app/clusters/icd-management-server/icd-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/icd-management-server/icd-management-server.cpp
Outdated
Show resolved
Hide resolved
lpbeliveau-silabs
force-pushed
the
feature/icd-stay-active
branch
from
February 22, 2024 16:24
533452a
to
3c49395
Compare
Applied comments about #if and clarifying maximum guaranteed stay active
lpbeliveau-silabs
force-pushed
the
feature/icd-stay-active
branch
from
February 22, 2024 16:26
3c49395
to
55f75e2
Compare
PR #32247: Size comparison from c5ab509 to 55f75e2 Increases (14 builds for bl602, bl702, bl702l, nrfconnect, stm32)
Decreases (1 build for bl702l)
Full report (14 builds for bl602, bl702, bl702l, nrfconnect, stm32)
|
PR #32247: Size comparison from c5ab509 to d400fe3 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (4 builds for bl702l, efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Feb 22, 2024
PR #32247: Size comparison from c5ab509 to f39186c Increases (3 builds for cc32xx, mbed)
Full report (4 builds for cc32xx, mbed, stm32)
|
… cluster without being ICD devices
lpbeliveau-silabs
force-pushed
the
feature/icd-stay-active
branch
from
February 22, 2024 21:43
f39186c
to
62ccf9c
Compare
PR #32247: Size comparison from 7e3774e to 62ccf9c Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (3 builds for bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
mkardous-silabs
approved these changes
Feb 23, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
* Implementation of StayActive request with test * Regenerated zap files * Added StayActiveRequest scenarios to the yaml test * Co-authored-by: Boris Zbarsky <[email protected]> Applied comments about #if and clarifying maximum guaranteed stay active * Added the #if back for platforms that build the icd-management-server cluster without being ICD devices * Applied suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
icd
Intermittently Connected Devices
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
system
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the StayActiveRequest command as described in the spec.
Fixes: #24259