-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Move OnActiveModeNotification out from onCheckInComplete #32159
Merged
yunhanw-google
merged 6 commits into
project-chip:master
from
yunhanw-google:feature/adjust_onActiveModeNotification
Feb 27, 2024
Merged
[ICD] Move OnActiveModeNotification out from onCheckInComplete #32159
yunhanw-google
merged 6 commits into
project-chip:master
from
yunhanw-google:feature/adjust_onActiveModeNotification
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32159: Size comparison from a71f814 to 6349f76 Decreases (1 build for efr32)
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, stm32)
|
yunhanw-google
force-pushed
the
feature/adjust_onActiveModeNotification
branch
from
February 16, 2024 02:20
6349f76
to
071c0f7
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
February 16, 2024 02:23
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
February 16, 2024 02:23
PR #32159: Size comparison from de5c6d5 to 9ee7950 Increases (2 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
force-pushed
the
feature/adjust_onActiveModeNotification
branch
from
February 23, 2024 20:54
9ee7950
to
5191511
Compare
yunhanw-google
force-pushed
the
feature/adjust_onActiveModeNotification
branch
from
February 23, 2024 20:57
ab8bba6
to
1e1d163
Compare
PR #32159: Size comparison from b7a781a to 1e1d163 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
mkardous-silabs
approved these changes
Feb 26, 2024
bzbarsky-apple
requested changes
Feb 26, 2024
bzbarsky-apple
approved these changes
Feb 26, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This PR does not have logic change, and just move OnActiveModeNotification out from onCheckInComplete, and into CheckInHandler and refreshKeySender, since OnActiveModeNotification is not responsibility for onCheckInComplete
-- When implementing darin/android CheckInDelegate, we should not call OnActiveModeNotification again.