-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Add sntp support to get real time on esp32 #32092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Feb 13, 2024
- Problem
- Chnages
- Testing
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 13, 2024 11:52
andy31415
reviewed
Feb 26, 2024
andy31415
reviewed
Feb 26, 2024
andy31415
reviewed
Feb 26, 2024
jadhavrohit924
force-pushed
the
feature/sntp-time
branch
from
February 27, 2024 07:18
222cf80
to
2e82631
Compare
PR #32092: Size comparison from a2d98f8 to a71e2b4 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jamesharrow
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@andy31415 @tcarmelveilleux Could you please review? |
tcarmelveilleux
approved these changes
Mar 1, 2024
dhrishi
reviewed
Mar 2, 2024
dhrishi
approved these changes
Mar 5, 2024
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
* [ESP32] Add sntp support to get real time on esp32 * Address review comments * Did some restructoring to address review comments * Addressed review comments * Again addressed review comments * Restyled by clang-format * Some renaming and error check * Update sntp array to accomodate null terminating charactor --------- Co-authored-by: Restyled.io <[email protected]>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
* [ESP32] Add sntp support to get real time on esp32 * Address review comments * Did some restructoring to address review comments * Addressed review comments * Again addressed review comments * Restyled by clang-format * Some renaming and error check * Update sntp array to accomodate null terminating charactor --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.