-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FaultInjection to help with IDM_1_3 automation testing #32045
Merged
mergify
merged 18 commits into
project-chip:master
from
tehampson:idm-1-3-fault-injection
Feb 15, 2024
Merged
Use FaultInjection to help with IDM_1_3 automation testing #32045
mergify
merged 18 commits into
project-chip:master
from
tehampson:idm-1-3-fault-injection
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
commented
Feb 9, 2024
tehampson
changed the title
Add FaultInjection to help with IDM_1_3 automation testing
Use FaultInjection to help with IDM_1_3 automation testing
Feb 9, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
February 9, 2024 17:26
PR #32045: Size comparison from 354d692 to 1024275 Increases above 0.2%:
Increases (18 builds for esp32, k32w, linux)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32045: Size comparison from 354d692 to f3823d7 Increases above 0.2%:
Increases (6 builds for esp32, k32w)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32045: Size comparison from 354d692 to af05f97 Increases above 0.2%:
Increases (6 builds for esp32, k32w)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
53 tasks
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
reviewed
Feb 15, 2024
andy31415
reviewed
Feb 15, 2024
andy31415
approved these changes
Feb 15, 2024
bzbarsky-apple
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDM_1_3 (client side testing) requires the all-clusters-app running on the TH to intentionally behave to identical InvokeRequests coming in. By using FaultInjection we are able to configure the TH to respond exactly how we want to the DUT to make sure the DUT behaves appropriately
Unit tests not added to
src/app/tests/TestCommandInteraction.cpp
, because current structure of CommandHandler does not lend itself well to unit testing and needs more of an integration test. After 1.3 release, I do have time carved out to refactorCommandHandler
andCommandResponseSender
to be more unit testable and easier to extend more features.TestOnlyTcIdm1_3FaultInjection
is not compiled into production code. Client testing automation is lacking ability to report failures so the approach of failing withVerifyOrDie
was taken so that QA doesn't incorrectly assume a test passes. The messages should be verbose enough to understand why the test failed.Test: