-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unset threadNetwork Scan #31704
Remove unset threadNetwork Scan #31704
Conversation
Unrelated to this PR, but why is mAttemptThreadNetworkScan an optional? Its only use seems to be a |
9089cbe
to
a37248c
Compare
PR #31704: Size comparison from cc5b41a to a37248c Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (63 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31704: Size comparison from 8fbe0a7 to 314c851 Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the src/controller core bit. I did not look at the java changes.
PR #31704: Size comparison from 6af0d14 to a2a2d8f Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31704: Size comparison from c1ae85c to bae0392 Increases (6 builds for bl602, bl702, bl702l, linux)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bae0392
to
2cfa94c
Compare
PR #31704: Size comparison from 6b026af to 2cfa94c Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31704: Size comparison from aee267d to a12156d Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31704: Size comparison from b742587 to 008c2d7 Increases (1 build for linux)
Decreases (1 build for linux)
Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
PR #31704: Size comparison from b742587 to babf282 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31704: Size comparison from c2f58e4 to 4c763d5 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
* divide android commissioning parameter * Fix countrycode copy issue * Restyled by clang-format * Update commissioningParameter --------- Co-authored-by: Restyled.io <[email protected]>
Fix #31703
The AttemptThreadNetworkScan value is set when the controller is initialized. If this value is set to true, the scan callback must be called, and will be called the first time.
However, if you call the commission API again for commissioning another device, the AttemptThreadNetworkScan value changes to false as the thread credentials are set.
To prevent this, it is necessary to modify the AttemptThreadNetworkScan value so that it does not change even if thread credentials are set.