Zap updates to resolve zap warnings for lock, thermostat , window and light-switch examples. #31620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
Signed-off-by: zhanghongyu <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
* remove lwipopts-thread.h. LWIP is not using with our thread implementation * Fix to build efr32 test driver with openthread Inet endpoint instead of lwip (so it uses the same config as our sample apps). Add to implement additional InetInterface method that were missing for the openthread inet endpoint interface. Make TestInetAddress.cpp work for CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
…p#32400) Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `41319af` to `671672b`. - [Commits](nanopb/nanopb@41319af...671672b) --- updated-dependencies: - dependency-name: third_party/nanopb/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ip#32405) Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `36e6bd6` to `cb086af`. - [Release notes](https://github.com/ARMmbed/mbedtls/releases) - [Commits](Mbed-TLS/mbedtls@36e6bd6...cb086af) --- updated-dependencies: - dependency-name: third_party/mbedtls/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sarthak-Shaha
force-pushed
the
update_zap_files_to_spec
branch
from
7af575f to
08eadd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Latest Zap shows error warning while building for the clusters / commands / attributes which are not up to the latest specifications. The zap files for lock app, thermostat , light-switch and silabs lighting are not up to the spec.
Fix / solution:
Made following changes
For all zap files
a. enabled cluster: Diagnostic Logs server : RetrieveLogsResponse command
a. Identify client : enabled identify outgoing commands
a. cluster: Identify, mandatory attribute: Identify Type.
TODO : Need to enable scenes cluster in Matter_1.3