-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Cluster Revision Update #31615
Merged
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_revision_6
Jan 25, 2024
Merged
[Scenes] Cluster Revision Update #31615
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_revision_6
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
LuDuda
January 22, 2024 22:22
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 22, 2024 22:22
PR #31615: Size comparison from a092fd1 to fee80ee Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Jan 22, 2024
jmartinez-silabs
approved these changes
Jan 23, 2024
andy31415
reviewed
Jan 24, 2024
andy31415
previously requested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change src/app/zap-templates/zcl/data-model/chip/scene.xml
from 5 to 6
lpbeliveau-silabs
force-pushed
the
feature/scenes_revision_6
branch
from
January 24, 2024 20:32
bfed5a6
to
69add25
Compare
PR #31615: Size comparison from 42c44d5 to 69add25 Full report (4 builds for cc32xx, mbed, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes_revision_6
branch
from
January 24, 2024 20:53
69add25
to
d45b358
Compare
PR #31615: Size comparison from 42c44d5 to d45b358 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated cluster revision in zap, matter and test files of the Scenes Management cluster.
Fixes: #31581