-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mStagingNetwork to the dataset in NVS after thread panid changed #31597
Merged
mergify
merged 1 commit into
project-chip:master
from
DejinChen:update_mStagingNetwork_after_init
Jan 24, 2024
Merged
update mStagingNetwork to the dataset in NVS after thread panid changed #31597
mergify
merged 1 commit into
project-chip:master
from
DejinChen:update_mStagingNetwork_after_init
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
January 22, 2024 11:58
pullapprove
bot
requested review from
tehampson,
tima-q,
vivien-apple,
tobiasgraf,
wiba-nordic,
turon,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 22, 2024 11:58
PR #31597: Size comparison from ed22840 to ca812cf Increases (22 builds for bl702, bl702l, cc13x4_26x4, cyw30739, k32w, nrfconnect, stm32)
Decreases (2 builds for bl702l)
Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, stm32)
|
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
Outdated
Show resolved
Hide resolved
DejinChen
force-pushed
the
update_mStagingNetwork_after_init
branch
from
January 23, 2024 07:07
ca812cf
to
9dadddb
Compare
DejinChen
changed the title
update mStagingNetwork to the dataset in NVS after thread init
update mStagingNetwork to the dataset in NVS after thread panid changed
Jan 23, 2024
PR #31597: Size comparison from db7d887 to 9dadddb Increases (41 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, nrfconnect, qpg, stm32, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Jan 23, 2024
src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp
Outdated
Show resolved
Hide resolved
DejinChen
force-pushed
the
update_mStagingNetwork_after_init
branch
from
January 24, 2024 02:36
9dadddb
to
e6eabbc
Compare
PR #31597: Size comparison from 7f5e208 to e6eabbc Increases (41 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, nrfconnect, qpg, stm32, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apple commissioning API checks the 'Networks' attribute of the 'Network Commissioning' cluster during on-network commissioning. If the attribute is not set, 'Thread Border Router Required' will be returned. The attribute remains null after a new end device joins a Thread network through OpenThread CLI commands or other methods. This issue arises because 'mStagingNetwork' is not promptly updated, even though the dataset has already been saved in NVS. To address this, update the 'mStagingNetwork' after activating an OpenThread dataset.