Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the value that checks for invalid values #31596

Closed
wants to merge 2 commits into from
Closed

Modify the value that checks for invalid values #31596

wants to merge 2 commits into from

Conversation

HunsupJung
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the app label Jan 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

PR #31596: Size comparison from ed22840 to 965989b

Increases (1 build for esp32)
platform target config section ed22840 965989b change % change
esp32 all-clusters-app m5stack (read only) 1240847 1240855 8 0.0
.flash.text 1234683 1234691 8 0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section ed22840 965989b change % change
bl602 lighting-app bl602 (read/write) 1426626 1426626 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157260 157260 0 0.0
.text 1093912 1093912 0 0.0
bl602+mfd (read/write) 1441058 1441058 0 0.0
.bss 85496 85496 0 0.0
.data 9456 9456 0 0.0
.rodata 156220 156220 0 0.0
.text 1109234 1109234 0 0.0
bl602+rpc (read/write) 1474386 1474386 0 0.0
.bss 93360 93360 0 0.0
.data 9864 9864 0 0.0
.rodata 164828 164828 0 0.0
.text 1125672 1125672 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1191483 1191483 0 0.0
.bss 11133 11133 0 0.0
.data 3664 3664 0 0.0
.rodata 106644 106644 0 0.0
.text 963254 963254 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1202303 1202303 0 0.0
.bss 11309 11309 0 0.0
.data 3648 3648 0 0.0
.rodata 105584 105584 0 0.0
.text 975008 975008 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1283099 1283099 0 0.0
.bss 19597 19597 0 0.0
.data 4224 4224 0 0.0
.rodata 122016 122016 0 0.0
.text 1038064 1038064 0 0.0
bl706-eth (read/write) 1010061 1010061 0 0.0
.bss 23692 23692 0 0.0
.data 3240 3240 0 0.0
.rodata 99964 99964 0 0.0
.text 755228 755228 0 0.0
bl706-wifi (read/write) 1242706 1242706 0 0.0
.bss 10577 10577 0 0.0
.data 3680 3680 0 0.0
.rodata 120944 120944 0 0.0
.text 985132 985132 0 0.0
bl702l lighting-app bl702l (read/write) 1161372 1161372 0 0.0
.bss 16328 16328 0 0.0
.data 5032 5032 0 0.0
.rodata 100648 100648 0 0.0
.text 956132 956132 0 0.0
bl702l+mfd (read/write) 1172772 1172772 0 0.0
.bss 16504 16504 0 0.0
.data 5008 5008 0 0.0
.rodata 99588 99588 0 0.0
.text 968454 968454 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780472 780472 0 0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90248 90248 0 0.0
.text 689960 689960 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 797984 797984 0 0.0
(read/write) 179100 179100 0 0.0
.bss 101060 101060 0 0.0
.data 3580 3580 0 0.0
.rodata 84640 84640 0 0.0
.text 713076 713076 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 786440 786440 0 0.0
(read/write) 173556 173556 0 0.0
.bss 95516 95516 0 0.0
.data 3580 3580 0 0.0
.rodata 111312 111312 0 0.0
.text 674860 674860 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738616 738616 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86032 86032 0 0.0
.text 652320 652320 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724240 724240 0 0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81872 81872 0 0.0
.text 642104 642104 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 571802 571802 0 0.0
(read/write) 207888 207888 0 0.0
.bss 201172 201172 0 0.0
.data 1592 1592 0 0.0
.rodata 84458 84458 0 0.0
.text 485220 485220 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626058 626058 0 0.0
(read/write) 208288 208288 0 0.0
.bss 201648 201648 0 0.0
.data 1520 1520 0 0.0
.rodata 106322 106322 0 0.0
.text 517616 517616 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 563495 563495 0 0.0
.app_xip_area 453417 453417 0 0.0
.bss 64920 64920 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 547119 547119 0 0.0
.app_xip_area 432305 432305 0 0.0
.bss 69616 69616 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566103 566103 0 0.0
.app_xip_area 457481 457481 0 0.0
.bss 63504 63504 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 561527 561527 0 0.0
.app_xip_area 449673 449673 0 0.0
.bss 66624 66624 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1045480 1045480 0 0.0
.bss 192800 192800 0 0.0
.data 2776 2776 0 0.0
.text 849884 849884 0 0.0
BRD4187C (read/write) 1107112 1107112 0 0.0
.bss 195148 195148 0 0.0
.data 3384 3384 0 0.0
.text 908560 908560 0 0.0
lock-app BRD4161A+wf200 (read/write) 1120884 1120884 0 0.0
.bss 188184 188184 0 0.0
.data 2800 2800 0 0.0
.text 929880 929880 0 0.0
window-app BRD4187C (read/write) 1143768 1143768 0 0.0
.bss 167140 167140 0 0.0
.data 3292 3292 0 0.0
.text 973316 973316 0 0.0
esp32 all-clusters-app c3devkit (read only) 1198470 1198470 0 0.0
(read/write) 1744576 1744576 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248064 248064 0 0.0
.flash.text 1198470 1198470 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1240847 1240855 8 0.0
(read/write) 529544 529544 0 0.0
.dram0.bss 80256 80256 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278236 278236 0 0.0
.flash.text 1234683 1234691 8 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 609576 609576 0 0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 609040 609040 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 695220 695220 0 0.0
.bss 67760 67760 0 0.0
.data 2788 2788 0 0.0
.text 581200 581200 0 0.0
light k32w0+release (read only) 598896 598896 0 0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 598360 598360 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787192 787192 0 0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 664304 664304 0 0.0
lock k32w0+release (read only) 580152 580152 0 0.0
(read/write) 78756 78756 0 0.0
.bss 66608 66608 0 0.0
.data 2164 2164 0 0.0
.text 579616 579616 0 0.0
linux air-purifier-app debug (read only) 2556517 2556517 0 0.0
(read/write) 127200 127200 0 0.0
.bss 46272 46272 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 180584 180584 0 0.0
.text 2200629 2200629 0 0.0
all-clusters-app debug (read only) 5722785 5722785 0 0.0
(read/write) 467320 467320 0 0.0
.bss 132176 132176 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 323416 323416 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1312 1312 0 0.0
.rodata 335900 335900 0 0.0
.text 4965651 4965651 0 0.0
all-clusters-minimal-app debug (read only) 5102945 5102945 0 0.0
(read/write) 234680 234680 0 0.0
.bss 127216 127216 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 96008 96008 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 281869 281869 0 0.0
.text 4588739 4588739 0 0.0
bridge-app debug (read only) 4530769 4530769 0 0.0
(read/write) 215984 215984 0 0.0
.bss 117816 117816 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 226293 226293 0 0.0
.text 4085907 4085907 0 0.0
chip-tool debug (read only) 12044169 12044169 0 0.0
(read/write) 515264 515264 0 0.0
.bss 94200 94200 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 408784 408784 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 436793 436793 0 0.0
.text 1090376 1090376 0 0.0
chip-tool-ipv6only arm64 (read only) 11584160 11584160 0 0.0
(read/write) 582744 582744 0 0.0
.bss 103256 103256 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 448240 448240 0 0.0
.dynamic 512 512 0 0.0
.got 20248 20248 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 345644 345644 0 0.0
.text 10353644 10353644 0 0.0
lighting-app debug+rpc+ui (read only) 5449729 5449729 0 0.0
(read/write) 224880 224880 0 0.0
.bss 118880 118880 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 349972 349972 0 0.0
.text 4855091 4855091 0 0.0
lock-app debug (read only) 4601169 4601169 0 0.0
(read/write) 203608 203608 0 0.0
.bss 113248 113248 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 252885 252885 0 0.0
.text 4138259 4138259 0 0.0
ota-provider-app debug (read only) 4255129 4255129 0 0.0
(read/write) 192688 192688 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 205813 205813 0 0.0
.text 3857443 3857443 0 0.0
ota-requestor-app debug (read only) 4371337 4371337 0 0.0
(read/write) 196968 196968 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 211701 211701 0 0.0
.text 3963459 3963459 0 0.0
shell debug (read only) 2860945 2860945 0 0.0
(read/write) 154720 154720 0 0.0
.bss 62184 62184 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 85416 85416 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186784 186784 0 0.0
.text 2501826 2501826 0 0.0
thermostat-no-ble arm64 (read only) 4429880 4429880 0 0.0
(read/write) 245064 245064 0 0.0
.bss 121624 121624 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 102824 102824 0 0.0
.dynamic 512 512 0 0.0
.got 12096 12096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 157468 157468 0 0.0
.text 3929804 3929804 0 0.0
tv-app debug (read only) 5534825 5534825 0 0.0
(read/write) 349232 349232 0 0.0
.bss 243136 243136 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 92344 92344 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 281493 281493 0 0.0
.text 5015395 5015395 0 0.0
tv-casting-app debug (read only) 9957161 9957161 0 0.0
(read/write) 342096 342096 0 0.0
.bss 155936 155936 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 176384 176384 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 376200 376200 0 0.0
.text 9109523 9109523 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2530360 2530360 0 0.0
.bss 220384 220384 0 0.0
.data 5208 5208 0 0.0
.text 1493044 1493044 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1094432 1094432 0 0.0
bss 129796 129796 0 0.0
rodata 111216 111216 0 0.0
text 805584 805584 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1214864 1214864 0 0.0
bss 121934 121934 0 0.0
rodata 141132 141132 0 0.0
text 801312 801312 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043220 1043220 0 0.0
bss 129522 129522 0 0.0
rodata 99076 99076 0 0.0
text 766896 766896 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835360 835360 0 0.0
(read/write) 1790772 1790772 0 0.0
.bss 195340 195340 0 0.0
.data 2640 2640 0 0.0
.text 1584404 1584404 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837664 837664 0 0.0
(read/write) 1712308 1712308 0 0.0
.bss 193060 193060 0 0.0
.data 2616 2616 0 0.0
.text 1508244 1508244 0 0.0
light cy8ckit_062s2_43012 (read only) 844360 844360 0 0.0
(read/write) 1635252 1635252 0 0.0
.bss 186548 186548 0 0.0
.data 2432 2432 0 0.0
.text 1437884 1437884 0 0.0
lock cy8ckit_062s2_43012 (read only) 817240 817240 0 0.0
(read/write) 1664556 1664556 0 0.0
.bss 213644 213644 0 0.0
.data 2456 2456 0 0.0
.text 1440068 1440068 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1121008 1121008 0 0.0
.bss 102224 102224 0 0.0
.data 808 808 0 0.0
.text 633388 633388 0 0.0
lock-app qpg6105+debug (read/write) 1085264 1085264 0 0.0
.bss 98520 98520 0 0.0
.data 852 852 0 0.0
.text 597640 597640 0 0.0
stm32 light STM32WB5MM-DK (read/write) 596685 596685 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78692 78692 0 0.0
.text 379328 379328 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825662 825662 0 0.0
bss 51020 51020 0 0.0
text 617620 617620 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1113036 1113036 0 0.0
bss 100776 100776 0 0.0
text 787840 787840 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1089560 1089560 0 0.0
bss 109920 109920 0 0.0
text 758102 758102 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934940 934940 0 0.0
bss 92988 92988 0 0.0
text 648796 648796 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826402 826402 0 0.0
bss 51064 51064 0 0.0
text 618492 618492 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 984344 984344 0 0.0
bss 79108 79108 0 0.0
text 699208 699208 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1096924 1096924 0 0.0
bss 100056 100056 0 0.0
text 773022 773022 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 970432 970432 0 0.0
bss 97408 97408 0 0.0
text 652546 652546 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953748 953748 0 0.0
bss 92564 92564 0 0.0
text 667650 667650 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884808 884808 0 0.0
bss 69136 69136 0 0.0
text 626108 626108 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825452 825452 0 0.0
bss 57380 57380 0 0.0
text 593032 593032 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705772 705772 0 0.0
bss 73640 73640 0 0.0
text 462164 462164 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828314 828314 0 0.0
bss 51200 51200 0 0.0
text 621414 621414 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882913 882913 0 0.0
bss 60848 60848 0 0.0
text 635046 635046 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850672 850672 0 0.0
bss 57668 57668 0 0.0
text 612290 612290 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844520 844520 0 0.0
bss 57984 57984 0 0.0
text 605954 605954 0 0.0

andy31415
andy31415 reviewed Jan 22, 2024
View reviewed changes
src/app/clusters/thermostat-server/thermostat-server.cpp Outdated
@@ -442,7 +442,7 @@ MatterThermostatClusterServerPreAttributeChangedCallback(const app::ConcreteAttr
}
auto RequestedSystemMode = static_cast<SystemModeEnum>(*value);
if (ControlSequenceOfOperation > ControlSequenceOfOperationEnum::kCoolingAndHeatingWithReheat ||
RequestedSystemMode > SystemModeEnum::kFanOnly)
RequestedSystemMode > SystemModeEnum::kSleep)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use EnusureKnownEnumValue(RequestedSystemMode) != SystemModeEnum::kUnknownValue ?

We cannot rely on ordering of enums or kSleep being the largest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reviewing :) I'll modify it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

PR #31596: Size comparison from ed22840 to b292351

Decreases (13 builds for cc13x4_26x4, cc32xx, k32w, mbed, stm32)
platform target config section ed22840 b292351 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780472 780440 -32 -0.0
.text 689960 689928 -32 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 797984 797952 -32 -0.0
.text 713076 713044 -32 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 786440 786392 -48 -0.0
.text 674860 674812 -48 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 738616 738584 -32 -0.0
.text 652320 652288 -32 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724240 724208 -32 -0.0
.text 642104 642072 -32 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 571802 571754 -48 -0.0
.text 485220 485172 -48 -0.0
lock CC3235SF_LAUNCHXL (read only) 626058 626026 -32 -0.0
.text 517616 517584 -32 -0.0
k32w contact k32w0+release (read only) 609576 609560 -16 -0.0
.text 609040 609024 -16 -0.0
k32w1+release (read/write) 695220 695180 -40 -0.0
.text 581200 581160 -40 -0.0
light k32w0+release (read only) 598896 598864 -32 -0.0
.text 598360 598328 -32 -0.0
k32w1+release (read/write) 787192 787160 -32 -0.0
.text 664304 664272 -32 -0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2530360 2530296 -64 -0.0
.text 1493044 1492980 -64 -0.0
stm32 light STM32WB5MM-DK (read/write) 596685 596645 -40 -0.0
.text 379328 379288 -40 -0.0
Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, mbed, stm32)
platform target config section ed22840 b292351 change % change
bl602 lighting-app bl602 (read/write) 1426626 1426626 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157260 157260 0 0.0
.text 1093912 1093912 0 0.0
bl602+mfd (read/write) 1441058 1441058 0 0.0
.bss 85496 85496 0 0.0
.data 9456 9456 0 0.0
.rodata 156220 156220 0 0.0
.text 1109234 1109234 0 0.0
bl602+rpc (read/write) 1474386 1474386 0 0.0
.bss 93360 93360 0 0.0
.data 9864 9864 0 0.0
.rodata 164828 164828 0 0.0
.text 1125672 1125672 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1191483 1191483 0 0.0
.bss 11133 11133 0 0.0
.data 3664 3664 0 0.0
.rodata 106644 106644 0 0.0
.text 963254 963254 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1202303 1202303 0 0.0
.bss 11309 11309 0 0.0
.data 3648 3648 0 0.0
.rodata 105584 105584 0 0.0
.text 975008 975008 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1283099 1283099 0 0.0
.bss 19597 19597 0 0.0
.data 4224 4224 0 0.0
.rodata 122016 122016 0 0.0
.text 1038064 1038064 0 0.0
bl706-eth (read/write) 1010061 1010061 0 0.0
.bss 23692 23692 0 0.0
.data 3240 3240 0 0.0
.rodata 99964 99964 0 0.0
.text 755228 755228 0 0.0
bl706-wifi (read/write) 1242706 1242706 0 0.0
.bss 10577 10577 0 0.0
.data 3680 3680 0 0.0
.rodata 120944 120944 0 0.0
.text 985132 985132 0 0.0
bl702l lighting-app bl702l (read/write) 1161372 1161372 0 0.0
.bss 16328 16328 0 0.0
.data 5032 5032 0 0.0
.rodata 100648 100648 0 0.0
.text 956132 956132 0 0.0
bl702l+mfd (read/write) 1172772 1172772 0 0.0
.bss 16504 16504 0 0.0
.data 5008 5008 0 0.0
.rodata 99588 99588 0 0.0
.text 968454 968454 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780472 780440 -32 -0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90248 90248 0 0.0
.text 689960 689928 -32 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 797984 797952 -32 -0.0
(read/write) 179100 179100 0 0.0
.bss 101060 101060 0 0.0
.data 3580 3580 0 0.0
.rodata 84640 84640 0 0.0
.text 713076 713044 -32 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 786440 786392 -48 -0.0
(read/write) 173556 173556 0 0.0
.bss 95516 95516 0 0.0
.data 3580 3580 0 0.0
.rodata 111312 111312 0 0.0
.text 674860 674812 -48 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 738616 738584 -32 -0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86032 86032 0 0.0
.text 652320 652288 -32 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724240 724208 -32 -0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81872 81872 0 0.0
.text 642104 642072 -32 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 571802 571754 -48 -0.0
(read/write) 207888 207888 0 0.0
.bss 201172 201172 0 0.0
.data 1592 1592 0 0.0
.rodata 84458 84458 0 0.0
.text 485220 485172 -48 -0.0
lock CC3235SF_LAUNCHXL (read only) 626058 626026 -32 -0.0
(read/write) 208288 208288 0 0.0
.bss 201648 201648 0 0.0
.data 1520 1520 0 0.0
.rodata 106322 106322 0 0.0
.text 517616 517584 -32 -0.0
k32w contact k32w0+release (read only) 609576 609560 -16 -0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 609040 609024 -16 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 695220 695180 -40 -0.0
.bss 67760 67760 0 0.0
.data 2788 2788 0 0.0
.text 581200 581160 -40 -0.0
light k32w0+release (read only) 598896 598864 -32 -0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 598360 598328 -32 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787192 787160 -32 -0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 664304 664272 -32 -0.0
lock k32w0+release (read only) 580152 580152 0 0.0
(read/write) 78756 78756 0 0.0
.bss 66608 66608 0 0.0
.data 2164 2164 0 0.0
.text 579616 579616 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2530360 2530296 -64 -0.0
.bss 220384 220384 0 0.0
.data 5208 5208 0 0.0
.text 1493044 1492980 -64 -0.0
stm32 light STM32WB5MM-DK (read/write) 596685 596645 -40 -0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78692 78692 0 0.0
.text 379328 379288 -40 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Jan 22, 2024
View reviewed changes
src/app/clusters/thermostat-server/thermostat-server.cpp
@@ -442,7 +442,7 @@ MatterThermostatClusterServerPreAttributeChangedCallback(const app::ConcreteAttr
}
auto RequestedSystemMode = static_cast<SystemModeEnum>(*value);
if (ControlSequenceOfOperation > ControlSequenceOfOperationEnum::kCoolingAndHeatingWithReheat ||
RequestedSystemMode > SystemModeEnum::kFanOnly)
EnsureKnownEnumValue(RequestedSystemMode) != SystemModeEnum::kUnknownValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check seems backwards. Was this tested? Given that it fails to compile, I assume not....

Please add a test that would have caught the old (incorrect) code.

@stale Stale
Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 22, 2024
@andy31415
Copy link
Contributor

Old PR with changes requested. Closing as stale.

@andy31415 andy31415 closed this Oct 11, 2024
@bzbarsky-apple
Copy link
Contributor

#36048 created to do the right check, with test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple requested changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

Assignees
No one assigned
Labels
app review - pending stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HunsupJung @andy31415 @bzbarsky-apple