-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Fix build and crash and add DeviceManagementCluster, EVSE mode and DeviceManagementCluster mode. #31591
[ESP32] Fix build and crash and add DeviceManagementCluster, EVSE mode and DeviceManagementCluster mode. #31591
Conversation
jadhavrohit924
commented
Jan 22, 2024
•
edited
Loading
edited
- Problems
- Changes
- Testing
PR #31591: Size comparison from ed22840 to a508f62 Increases (3 builds for nrfconnect, psoc6)
Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
a508f62
to
4e76a80
Compare
PR #31591: Size comparison from ed22840 to 4e76a80 Increases (7 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can align to Linux/main.cpp using unique_ptr style that may help make it easier to align updates.
PR #31591: Size comparison from ed22840 to 7fb2052 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, stm32, telink)
Decreases (22 builds for cc13x4_26x4, cyw30739, efr32, k32w, linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, stm32, telink)
|
7fb2052
to
a4848d0
Compare
PR #31591: Size comparison from 166c4b5 to a4848d0 Increases (7 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@andy31415 Can you please review? |