Documentation for YAML tests #31575
Merged
Documentation for YAML tests #31575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls from the test harness presentations in Korea and Geneva
github-actions
bot
added
documentation
|
PR #31575: Size comparison from 0ff709f to bca5a7b Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #31575: Size comparison from 0ff709f to 8f8d2f6 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
|
PR #31575: Size comparison from 0ff709f to a0e49f3 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #31575: Size comparison from 0ff709f to 7b5d182 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #31575: Size comparison from 0ff709f to 8a03f47 Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
|
|
PR #31575: Size comparison from 0ff709f to b2922ed Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #31575: Size comparison from 0ff709f to ee2f902 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
|
PR #31575: Size comparison from 0ff709f to c1960d7 Increases above 0.2%:
Increases (2 builds for efr32, linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
cecille
changed the title
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
mhazley
approved these changes
Jan 23, 2024
tehampson
reviewed
Jan 23, 2024
| @@ -0,0 +1,35 @@ | |||
| <!--- | |||
There was a problem hiding this comment.
Something seems off with the end result, when looking at preview and what got merged in github
https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/yaml_schema.md
tehampson
reviewed
Jan 23, 2024
| "-->\n\n") | ||
|
|
||
|
|
||
| def get_type_list_and_vars(typetuple) -> (list[type], bool): |
There was a problem hiding this comment.
nit, please add function documentation to explain what the tuple return is. It wasn't originally obvious what the what the bool was for
There was a problem hiding this comment.
added - the bool is whether variables are supported.
tehampson
reviewed
Jan 23, 2024
| try: | ||
| typelist = list(typetuple) | ||
| if str in typelist: | ||
| reduced = [t for t in typelist if t != str] |
There was a problem hiding this comment.
If I am being honest I don't actually understand the t != str is checking here? I would expect either:
t != "str", or isinstance(t, str)
There was a problem hiding this comment.
yeah, it's a comparison to a class. It's not an instance though - it's the class of the type, which is why it looks weird. ie, the yaml parser has a tuple of classes that are allowed. So t will directly be str class, rather than an instance of the class or a string of the class name. That happens because the parser is coded weirdly. I've added a comment to explain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes material from https://groups.csa-iot.org/wg/matter-csg/document/29088 and https://groups.csa-iot.org/wg/matter-csg/document/32281.