-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing_pw library #31550
Add testing_pw library #31550
Conversation
PR #31550: Size comparison from 049fef0 to 3f943a6 Full report (5 builds for cc32xx, mbed, qpg)
|
PR #31550: Size comparison from 049fef0 to ebfa828 Increases (7 builds for esp32, linux, nrfconnect, telink)
Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about the name, maybe pw_testing_library
or pw_tests_wrapper
may be clearer. However as a concept adding a checkmark.
ebfa828
to
0cb3985
Compare
I've renamed the target and related library. |
PR #31550: Size comparison from ed22840 to 0cb3985 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR related to #29682
Problem
pw_unit_test
support project. If I want to link thepw_unit_test
library to embedded platforms, I need to duplicate the pigweed backend configuration in gn related files and later in CMakeFiles for those platforms.Solution
pw_unit_test
intolibCHIP_tests
and create a proxy function which will callRUN_ALL_TESTS
. This allows me not to duplicate the Pigweed backend settings. Unit tests for the ESP32 platform don't uselibCHIP_tests
, so I want to create a separatelibPWTestsWrapper
for them.