-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable batch commands for the linux example all-clusters-app #31531
Merged
tehampson
merged 6 commits into
project-chip:master
from
tehampson:enable-batch-command-for-linux-app-clusters
Jan 19, 2024
Merged
Enable batch commands for the linux example all-clusters-app #31531
tehampson
merged 6 commits into
project-chip:master
from
tehampson:enable-batch-command-for-linux-app-clusters
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
commented
Jan 19, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
January 19, 2024 01:56
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 19, 2024 01:56
PR #31531: Size comparison from 45aa5b7 to 3ebd86c Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31531: Size comparison from 45aa5b7 to 6e372cb Increases above 0.2%:
Increases (14 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31531: Size comparison from 45aa5b7 to 0f99fce Increases above 0.2%:
Increases (24 builds for cc13x4_26x4, esp32, linux, nrfconnect, telink)
Decreases (9 builds for cc13x4_26x4, efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 19, 2024
bauerschwan
approved these changes
Jan 19, 2024
jmartinez-silabs
approved these changes
Jan 19, 2024
bzbarsky-apple
approved these changes
Jan 19, 2024
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #31516
This set the default value of 1 to
CHIP_CONFIG_MAX_PATHS_PER_INVOKE
, which is what the default is already insrc/lib/core/CHIPConfig.h
, into the buildconfig header. This allows gn build system to set the value to whatever is desired. For example in the linux all clusters app we want to set this to 5.