-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Fix ordering issue when triggering a report on Active mode #31524
Merged
mergify
merged 6 commits into
project-chip:master
from
mkardous-silabs:feature/report_on_active_mode
Jan 20, 2024
Merged
[ICD] Fix ordering issue when triggering a report on Active mode #31524
mergify
merged 6 commits into
project-chip:master
from
mkardous-silabs:feature/report_on_active_mode
Jan 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31524: Size comparison from a033426 to bde385d Increases (14 builds for efr32, k32w, qpg, telink)
Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
commented
Jan 19, 2024
jmartinez-silabs
approved these changes
Jan 19, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248 and
hicklin
January 19, 2024 16:40
pullapprove
bot
requested review from
saurabhst,
sharadb-amazon,
tcarmelveilleux,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 19, 2024 16:40
PR #31524: Size comparison from a033426 to 3f21f92 Increases above 0.2%:
Increases (16 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect)
Full report (16 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect)
|
tcarmelveilleux
approved these changes
Jan 19, 2024
mkardous-silabs
force-pushed
the
feature/report_on_active_mode
branch
from
January 19, 2024 23:01
3f21f92
to
89bdff0
Compare
PR #31524: Size comparison from e553129 to 89bdff0 Increases (14 builds for efr32, k32w, qpg, telink)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a subscription report was being sent out due to a max interval, the ICDManager was only entering active mode because of an ExchangeContext being created.
Since the ExchangeContext was created after the payload generation, no new data could be added to the subscription being sent out.
Adding a
OnSubscriptionReport
callback to transition the ICD to active mode before the payload is generated to allow the ICDManager to add any data it generates during the transition.