-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/electrical energy & power measurement clusters #31518
Feature/electrical energy & power measurement clusters #31518
Conversation
PR #31518: Size comparison from 005813f to dc8756b Increases above 0.2%:
Increases (30 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (22 builds for efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good.
Some additional comments - I didn't it instantiated into all-clusters-app etc.
(that's probably worth splitting into another PR).
There would need to be a delegate instance created, and it would be good to have some helper functions to created Events etc.
My VSCode does auto CPP code tidying when you save, that might help alignment issues.
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-power-measurement-server/electrical-power-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-power-measurement-server/electrical-power-measurement-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/electrical-power-measurement-server/electrical-power-measurement-server.h
Outdated
Show resolved
Hide resolved
eea326a
to
3f7447d
Compare
PR #31518: Size comparison from 039cbab to 3f7447d Increases (5 builds for nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #31518: Size comparison from e03a83c to 5677719 Increases above 0.2%:
Increases (32 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31518: Size comparison from e03a83c to 2e1d2c9 Increases above 0.2%:
Increases (20 builds for cc13x4_26x4, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (1 build for linux)
Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #31518: Size comparison from 09324e7 to 8f1edea Increases above 0.2%:
Increases (32 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31518: Size comparison from 09324e7 to 3b4ad35 Increases above 0.2%:
Increases (32 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31518: Size comparison from 09324e7 to 1203545 Increases above 0.2%:
Increases (32 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31518: Size comparison from 09324e7 to 272ca37 Increases above 0.2%:
Increases (22 builds for cc13x4_26x4, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (4 builds for linux, nrfconnect, psoc6)
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #31518: Size comparison from 09324e7 to 3fae3b4 Increases above 0.2%:
Increases (31 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for efr32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31518: Size comparison from 09324e7 to a951bf1 Increases above 0.2%:
Increases (31 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for efr32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Yeah, I mistakenly marked ElectricalEnergyMeasurement as having FeatureMap in attributeAccessInterfaceAttributes, but fixing that just revealed a different issue with a mismatch between the default feature set and the stub's selected attributes. Also, it wasn't unregistering itself on destruction, which caused a freed memory access in UnregisterMatchingAttributeAccessInterfaces during shutdown, but all those are now resolved and the tests are passing. |
PR #31518: Size comparison from 6fd32ba to d87f897 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (9 builds for linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…nnectedhomeip into granbery/electrical_measurement
PR #31518: Size comparison from 6fd32ba to 5ac33e5 Increases above 0.2%:
Increases (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
Decreases (4 builds for linux, nrfconnect)
Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
PR #31518: Size comparison from cd3e498 to 94d96e4 Increases above 0.2%:
Increases (34 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (9 builds for efr32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
This PR adds the XML for the Electrical Energy and Power Measurement Clusters and basic implementations of servers.
This is based on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7830
Changes
src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml
src/app/zap-templates/zcl/data-model/chip/electrical-power-measurement-cluster.xml
src/app/clusters/electrical-energy-measurement-server/
andsrc/app/clusters/electrical-power-measurement-server/
Testing
Fixes: #31095
Fixes: #31030