-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AlarmMap to AlarmBitmap. #31517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
January 18, 2024 16:33
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 18, 2024 16:33
bzbarsky-apple
force-pushed
the
rename-alarm-map
branch
from
January 18, 2024 16:34
350f80e
to
ed019da
Compare
yunhanw-google
approved these changes
Jan 18, 2024
PR #31517: Size comparison from 4ac4a7f to ed019da Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Jan 18, 2024
Adding skip-protocol-compatibility label, because this is a purposeful rename, with compat shims in place. |
bzbarsky-apple
force-pushed
the
rename-alarm-map
branch
from
January 18, 2024 19:51
ed019da
to
d9218e6
Compare
The spec renamed this in CHIP-Specifications/connectedhomeip-spec#7628 Fixes project-chip#29667
ReneJosefsen
approved these changes
Jan 18, 2024
bzbarsky-apple
force-pushed
the
rename-alarm-map
branch
from
January 18, 2024 20:22
d9218e6
to
dfae661
Compare
PR #31517: Size comparison from 8efb6aa to dfae661 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
fast track
review - pending
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec renamed this in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7628
Fixes #29667
REVIEW NOTE: Only the first of the three changesets is hand-written. The other two are both auto-generated.