-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add OnPeerTypeChange for dynamic ICD #31340
Merged
yunhanw-google
merged 11 commits into
project-chip:master
from
erjiaqing:icd/readclient-dynamic-icd
Jan 18, 2024
Merged
[ICD] Add OnPeerTypeChange for dynamic ICD #31340
yunhanw-google
merged 11 commits into
project-chip:master
from
erjiaqing:icd/readclient-dynamic-icd
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
lib
controller
app
core
labels
Jan 10, 2024
erjiaqing
force-pushed
the
icd/readclient-dynamic-icd
branch
from
January 10, 2024 13:27
73d4068
to
e3d12fe
Compare
PR #31340: Size comparison from fe5c09c to e3d12fe Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
erjiaqing
force-pushed
the
icd/readclient-dynamic-icd
branch
from
January 15, 2024 02:13
e3d12fe
to
02d522a
Compare
PR #31340: Size comparison from 4676d27 to d8e447c Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248 and
hicklin
January 16, 2024 17:03
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
January 16, 2024 17:03
yunhanw-google
changed the title
[WIP] [icd] add OnPeerTypeChange for dynamic ICD
[ICD] Add OnPeerTypeChange for dynamic ICD
Jan 16, 2024
Fix typo nolonger
yunhanw-google
approved these changes
Jan 16, 2024
bzbarsky-apple
approved these changes
Jan 17, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #30812
This PR adds a function to InteractionModelEngine and ReadClient
kNormal -> kLITICD
: Just set the kIsPeerLit flagkLITICD -> kNormal
: Also callsOnActiveModeNotification
.Fixes #31111