Add supportedThreadFeatures, threadVersion and SupportedWiFiBands attributes to some reference apps #31328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang and
nivi-apple
bzbarsky-apple
approved these changes
Jan 10, 2024
|
After discussing with @tcarmelveilleux, I reverted the config changes to the sample apps other than all-cluster-apps for now as we want to avoid users copying non-spec compliant configs from sample apps. We are looking into ways to ensure that the attribute list matches the device network type in a compliant way. In combination with a valid feature-amp attribute, compliance tests should be able to validate devices. |
jmartinez-silabs
force-pushed
the
add_attributes_to_nwc
branch
from
bcdd1b8 to
5a3f60e
Compare
|
PR #31328: Size comparison from 262cb44 to 5a3f60e Decreases (2 builds for qpg)
Full report (2 builds for qpg)
|
jmartinez-silabs
force-pushed
the
add_attributes_to_nwc
branch
from
5a3f60e to
f06ee5c
Compare
|
PR #31328: Size comparison from 262cb44 to 85024f8 Increases (10 builds for bl702l, esp32, linux, nrfconnect)
Decreases (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
force-pushed
the
add_attributes_to_nwc
branch
from
85024f8 to
6eed2e2
Compare
|
PR #31328: Size comparison from 2869798 to 6eed2e2 Increases (9 builds for esp32, linux, nrfconnect)
Decreases (57 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…res, threadVersion and SupportedWiFiBands attributes of the network commissioning cluster
…Return UnsupportedAttribute otherwise.
jmartinez-silabs
force-pushed
the
add_attributes_to_nwc
branch
from
6eed2e2 to
20b45f5
Compare
|
PR #31328: Size comparison from 7ef397e to 20b45f5 Increases (47 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (21 builds for bl702l, efr32, esp32, linux, nrfconnect, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31328: Size comparison from 7ef397e to 37b874e Increases (46 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (22 builds for bl702l, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31328: Size comparison from 7ef397e to 78d5e1a Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for bl702l, linux, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #31328: Size comparison from 7ef397e to 7ed08cd Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702l, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Jan 17, 2024
…ributes to some reference apps (project-chip#31328) * Update zap file of some reference apps to enable supportedThreadFeatures, threadVersion and SupportedWiFiBands attributes of the network commissioning cluster * regen all * Revert change to examples other than all-clusters apps * Gate the encoding base on the Network type define enablement define. Return UnsupportedAttribute otherwise. * fix conflicts * fixup * Rework condition logic to fix CI issue with linux all-cluster-app * Fix Clang-tidy validation
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the zap file of some reference apps to enable
attributes of the network commissioning cluster
The affected apps are :
lock-applighting-applit-icd-server-appNOTE this enables both Wifi and Thread specific clusters for validation purposes regardless of the platform network technology. This should not be the normal configuration of a product and that is why it is not applied to all sample apps - Open to better suggestion about