-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml: Add PDC support to Network Commissioning cluster #30191
Merged
ksperling-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:pdc-nc-cluster-xml
Nov 8, 2023
Merged
xml: Add PDC support to Network Commissioning cluster #30191
ksperling-apple
merged 8 commits into
project-chip:master
from
ksperling-apple:pdc-nc-cluster-xml
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30191: Size comparison from 2c5fa26 to 1d6859d Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/network-commissioning-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/network-commissioning-cluster.xml
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Nov 5, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
November 7, 2023 05:54
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
November 7, 2023 05:54
src/app/zap-templates/zcl/data-model/chip/network-commissioning-cluster.xml
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Nov 7, 2023
ksperling-apple
force-pushed
the
pdc-nc-cluster-xml
branch
from
November 7, 2023 20:37
0ef46e4
to
0f4c877
Compare
PR #30191: Size comparison from 2d62ad1 to 0f4c877 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for bl702l)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
zap_regen_all does not produce any code changes for this change.
ScanNetworks, RemoveNetwork, ReorderNetwork, and ConnectNetwork are not mandatory.
ksperling-apple
force-pushed
the
pdc-nc-cluster-xml
branch
from
November 8, 2023 02:52
0f4c877
to
fb44bed
Compare
PR #30191: Size comparison from 155917e to fb44bed Increases (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #30191: Size comparison from 155917e to f589dba Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for bl702l)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30191: Size comparison from 155917e to c2ac2f3 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for bl702l)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29969