-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Fan Control Cluster
to spec
#30182
Conversation
PR #30182: Size comparison from 94a6f93 to f61cb87 Increases (2 builds for cc32xx)
Decreases (4 builds for cc32xx, nrfconnect)
Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix #29406 ? Looks like it does.
PR #30182: Size comparison from 94a6f93 to 32e75a9 Increases (14 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (4 builds for cc32xx, linux, psoc6)
Full report (30 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
…omeip into fan_control_to_spec
PR #30182: Size comparison from 94a6f93 to 8b9b4f9 Increases (14 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (16 builds for cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30182: Size comparison from 94a6f93 to 282bec7 Increases above 0.2%:
Increases (22 builds for cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (11 builds for cc32xx, linux, nrfconnect, psoc6)
Full report (23 builds for cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30182: Size comparison from 94a6f93 to 3786017 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (51 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This part is pretty frustrating. It used to be |
PR #30182: Size comparison from 1730e11 to 9db30a5 Increases (13 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (15 builds for cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I only updated to 1.2 spec (not 1.3 which has slightly newer revision);
Changes
High
instead ofOn
in the nameFixes #29406