-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microwave oven mode cluster xml #30018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
October 27, 2023 01:00
PR #30018: Size comparison from 739f72a to 131180d Increases above 0.2%:
Increases (17 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (1 build for esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30018: Size comparison from 1890490 to ff58c27 Increases above 0.2%:
Increases (17 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (1 build for esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/microwave-oven-mode-cluster.xml
Outdated
Show resolved
Hide resolved
PR #30018: Size comparison from dafa412 to a985e2c Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30018: Size comparison from e5e93bf to dbfebf3 Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 1, 2023
andy31415
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Matter 1.3 clusters missing XML and generated code for Microwave Oven Mode cluster
Solution:
Create XML
Update below files:
.github/workflows/tests.yaml
scripts/rules.matterlint
src/app/zap-templates/zcl/data-model/all.xml
src/app/zap-templates/zcl/zcl-with-test-extensions.json
src/app/zap-templates/zcl/zcl.json
src/app/zap_cluster_list.json
src/controller/data_model/BUILD.gn
src/controller/data_model/controller-clusters.zap
Add new cluster XML
src/app/zap-templates/zcl/data-model/chip/microwave-oven-mode-cluster.xml
Testing:
Regen all