Remove the startupmode from the rvc clusters #29949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
pullapprove
bot
added
review - pending
and removed
examples
darwin
controller
app
labels
|
PR #29949: Size comparison from a010ae4 to 1f80acc Increases (1 build for esp32)
Decreases (23 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 24, 2023
tehampson
reviewed
Oct 24, 2023
…lusters-app's zap file.
|
PR #29949: Size comparison from a010ae4 to 2849a39 Increases above 0.2%:
Increases (36 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (15 builds for cc13x4_26x4, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hicklin
added
the
skip-protocol-compatibility
…cluster as disabled in the CI PICS file.
|
PR #29949: Size comparison from a010ae4 to 0596377 Increases above 0.2%:
Increases (36 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (15 builds for cc13x4_26x4, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
plauric
approved these changes
Oct 25, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Removed the StartUpMode attribute from the RvcRunMode and the RvcCleanMode cluster XMLs. * Regenerated zap files. * Removed the StartUpMode attribute for the RVC clusters from the all-clusters-app's zap file. * Marked the StartUpMode attribute for the RvcRunMode and RvcCleanMode cluster as disabled in the CI PICS file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
StartUpModeattribute from the RvcRunMode and RvcCleanMode clusters.note this is not something that is currently reflected in the spec. See issue below.
After discussions with Boris Zbarsky and Petru Lauric, it was agreed that these clusters should not be used by any other device other than the RVC. Given that this device doesn't support these attributes, as per spec, it was reasoned that the
StartUpModeattribute dose not need to be supported by the RVC mode clusters. Removing it would make the client APIs simpler and less confusing.This change will require changes to the test plan and scripts, and the spec. These changes will come later and there are issues to track these changes, see below. This change doesn't brake the current tests as the testing of this attribute is gated by a PICS code which is not expected to enable by the devices that use these clusters.
Spec issue.
RvcRunMode test plan issue.
RvcCleanMode test plan issue.