[BouffaloLab] Update BouffaloLab platform requirements #29480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
|
PR #29480: Size comparison from d1fa6ee to 2cb2aa1 Increases (1 build for telink)
Decreases (1 build for telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
requested changes
Sep 30, 2023
There was a problem hiding this comment.
@shchen-Lab please update the summary of the PR to help reviewers undestand what requirements were updated and why. It says right there: !!!!!!!!!! Please delete the instructions below and replace with PR description
|
PR #29480: Size comparison from fc44549 to e02c630 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #29480: Size comparison from f34b13c to cf481c7 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
|
PR #29480: Size comparison from 62cdbab to e803cb2 Full report (43 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29480: Size comparison from a9d7401 to 4746219 Decreases (1 build for bl702l)
Full report (43 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29480: Size comparison from 73b400d to eb2ccb6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This description seems incomplete - you seem to be adding module not just specifying versions. Given that boufallolab examples already compile could you explain the change? As a reviewer I would like to understand where this is heading because for now we share pip modules across all platforms (our fault: we use the free version of buildjet so we cache only one build environment) so any modules interacts with all other platforms: fixing versions has higher chances of conflicts and more dependencies will cause images to become slightly larger (probably not much, but would still like to understand and ensure the images are minimal). |
jmartinez-silabs
approved these changes
Oct 17, 2023
andy31415
reviewed
Oct 17, 2023
andy31415
requested changes
Oct 17, 2023
There was a problem hiding this comment.
I unpacked https://pypi.org/project/bflb-iot-tool/1.8.6/#files and I see:
install_requires=[
'ecdsa>=0.15',
'pycryptodome==3.9.8',
'bflb-crypto-plus==1.0',
'pycklink>=0.1.1',
'pyserial==3.5',
'pylink-square==0.5.0',
'portalocker==2.0.0'
],
in setup.py
So you do not need these requirements here.
You are right， but use "source ./scripts/activate.sh -p bouffalolab" to install bflb-iot-tool will appear dependency conflicts. I have contact bflb-iot -tool developer try reslove this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bflb-iot-tool need to specify serial module and signature module and encryption module, this is used to signature and encrypt firmware.