Skip to content

Commit

Permalink
fix: Invert boolean return in GetAcknowledgementsRequest (#37014)
Browse files Browse the repository at this point in the history
* fix: Invert boolean return in GetAcknowledgementsRequest

The GetAcknowledgementsRequest was returning an incorrect boolean value,
causing unexpected behavior. This change inverts the return value to
fix the logical error.

Testing:
- Issue identified during test plan script development
- Test plan changes will be referenced in a separate change
  • Loading branch information
swan-amazon authored Jan 11, 2025
1 parent 448930e commit d5e9829
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/app/server/DefaultTermsAndConditionsProvider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ CHIP_ERROR chip::app::DefaultTermsAndConditionsProvider::GetAcknowledgementsRequ

TermsAndConditions requiredTermsAndConditions = requiredTermsAndConditionsMaybe.Value();
TermsAndConditions acceptedTermsAndConditions = acceptedTermsAndConditionsMaybe.Value();
outAcknowledgementsRequired = requiredTermsAndConditions.Validate(acceptedTermsAndConditions);

bool requiredTermsAndConditionsAreAccepted = requiredTermsAndConditions.Validate(acceptedTermsAndConditions);
outAcknowledgementsRequired = !requiredTermsAndConditionsAreAccepted;
return CHIP_NO_ERROR;
}

Expand Down

0 comments on commit d5e9829

Please sign in to comment.