Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson committed Jan 19, 2024
1 parent 6e372cb commit d4c4b5e
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion examples/all-clusters-app/linux/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,3 @@ matter_log_json_payload_decode_full = true
matter_log_json_payload_hex = true
chip_enable_smoke_co_trigger = true
chip_enable_boolean_state_configuration_trigger = true
chip_max_paths_per_invoke = 5
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@

// Marks that a ModeBase Derived cluster is being used.
#define EMBER_AF_PLUGIN_MODE_BASE

// Enable batching of up to 5 commands.
#define CHIP_CONFIG_MAX_PATHS_PER_INVOKE 5
1 change: 0 additions & 1 deletion src/lib/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ buildconfig_header("chip_buildconfig") {
"CHIP_CONFIG_BIG_ENDIAN_TARGET=${chip_target_is_big_endian}",
"CHIP_CONFIG_TLV_VALIDATE_CHAR_STRING_ON_WRITE=${chip_tlv_validate_char_string_on_write}",
"CHIP_CONFIG_TLV_VALIDATE_CHAR_STRING_ON_READ=${chip_tlv_validate_char_string_on_read}",
"CHIP_CONFIG_MAX_PATHS_PER_INVOKE=${chip_max_paths_per_invoke}",
"CHIP_CONFIG_SENDING_BATCH_COMMANDS_ENABLED=${chip_enable_sending_batch_commands}",
]

Expand Down
2 changes: 0 additions & 2 deletions src/lib/core/core.gni
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ declare_args() {
chip_tlv_validate_char_string_on_write = true
chip_tlv_validate_char_string_on_read = false

chip_max_paths_per_invoke = 1

chip_enable_sending_batch_commands =
current_os == "linux" || current_os == "mac" || current_os == "ios"
}
Expand Down

0 comments on commit d4c4b5e

Please sign in to comment.