Skip to content

Commit

Permalink
Fixing CI build documentation error
Browse files Browse the repository at this point in the history
  • Loading branch information
pgregorr-amazon committed Jan 13, 2025
1 parent ee0c8e6 commit cf9f463
Showing 5 changed files with 9 additions and 15 deletions.
2 changes: 1 addition & 1 deletion examples/tv-casting-app/APIs.md
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ correspond to the client being built.

`CHIP_DEVICE_CONFIG_DEVICE_VENDOR_ID` and `CHIP_DEVICE_CONFIG_DEVICE_PRODUCT_ID`
can be obtained during the CSA certification of your mobile app. The Matter SDK
has pre-configured default values for them in the
has pre-configured sample/test values for them in the
[CHIPDeviceConfig.h](https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/CHIPDeviceConfig.h)
file.

8 changes: 4 additions & 4 deletions examples/tv-casting-app/android/README.md
Original file line number Diff line number Diff line change
@@ -59,16 +59,16 @@ JDK version on MacOS for Apple Silicon is 'openjdk 17.0.1' or above.
If you attempt to build with an incompatible Java version, you may encounter the
following error:

```log
```text
Unsupported class file major version XX
```

This error occurs when the Java version being used is not compatible with the
Gradle version in your project.

See the Android
[README.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/platforms/android/android_building.md#gradle--jdk-version)
for more info about the supported Gradle & JDK Version.
See the
[android_building.md](https://github.com/project-chip/connectedhomeip/blob/master/docs/platforms/android/android_building.md)
file for more info about the supported Gradle & JDK Version.

You can verify your current Java version by running:

9 changes: 3 additions & 6 deletions examples/tv-casting-app/tv-casting-common/core/Attribute.h
Original file line number Diff line number Diff line change
@@ -85,8 +85,7 @@ class Attribute
// FindOrEstablishSession success handler
[](void * _context, chip::Messaging::ExchangeManager & exchangeMgr, const chip::SessionHandle & sessionHandle) {
ReadAttributeContext<TypeInfo> * _attributeContext = static_cast<ReadAttributeContext<TypeInfo> *>(_context);
ChipLogProgress(AppServer,
"<Attribute>::Read() success endpoint->GetCastingPlayer()->FindOrEstablishSession()");
ChipLogProgress(AppServer, "<Attribute>::Read() Found or established session");

// Read attribute
MediaClusterBase mediaClusterBase(exchangeMgr, sessionHandle, _attributeContext->mEndpoint->GetId());
@@ -179,8 +178,7 @@ class Attribute
[](void * _context, chip::Messaging::ExchangeManager & exchangeMgr, const chip::SessionHandle & sessionHandle) {
WriteAttributeContext<typename TypeInfo::Type> * _attributeContext =
static_cast<WriteAttributeContext<typename TypeInfo::Type> *>(_context);
ChipLogProgress(AppServer,
"<Attribute>::Write() success endpoint->GetCastingPlayer()->FindOrEstablishSession()");
ChipLogProgress(AppServer, "<Attribute>::Write() Found or established session");

// Write attribute
MediaClusterBase mediaClusterBase(exchangeMgr, sessionHandle, _attributeContext->mEndpoint->GetId());
@@ -262,8 +260,7 @@ class Attribute
[](void * _context, chip::Messaging::ExchangeManager & exchangeMgr, const chip::SessionHandle & sessionHandle) {
SubscribeAttributeContext<TypeInfo> * _attributeContext =
static_cast<SubscribeAttributeContext<TypeInfo> *>(_context);
ChipLogProgress(AppServer,
"<Attribute>::Subscribe() success endpoint->GetCastingPlayer()->FindOrEstablishSession()");
ChipLogProgress(AppServer, "<Attribute>::Subscribe() Found or established session");

// Subscribe to attribute
MediaClusterBase mediaClusterBase(exchangeMgr, sessionHandle, _attributeContext->mEndpoint->GetId());
3 changes: 1 addition & 2 deletions examples/tv-casting-app/tv-casting-common/core/Command.h
Original file line number Diff line number Diff line change
@@ -61,8 +61,7 @@ class Command
// FindOrEstablishSession success handler
[](void * _context, chip::Messaging::ExchangeManager & exchangeMgr, const chip::SessionHandle & sessionHandle) {
CommandContext<RequestType> * _commandContext = static_cast<CommandContext<RequestType> *>(_context);
ChipLogProgress(AppServer,
"<Command>::Invoke() success endpoint->GetCastingPlayer()->FindOrEstablishSession()");
ChipLogProgress(AppServer, "<Command>::Invoke() Found or established session");

// Invoke command
MediaClusterBase cluster(exchangeMgr, sessionHandle, _commandContext->mEndpoint->GetId());
Original file line number Diff line number Diff line change
@@ -50,14 +50,12 @@ void ChipDeviceEventHandler::Handle(const chip::DeviceLayer::ChipDeviceEvent * e
else if (event->Type == chip::DeviceLayer::DeviceEventType::kBindingsChangedViaCluster &&
CastingPlayer::GetTargetCastingPlayer() != nullptr)
{
ChipLogProgress(AppServer, "ChipDeviceEventHandler::Handle() event kBindingsChangedViaCluster");
HandleBindingsChangedViaCluster(event, arg, runPostCommissioning, targetNodeId, targetFabricIndex);
}
else if (event->Type == chip::DeviceLayer::DeviceEventType::kCommissioningComplete)
{
// True when device completes initial commissioning (PASE).
// Note: Not triggered for subsequent CASE sessions established via CastingPlayer::FindOrEstablishSession()
ChipLogProgress(AppServer, "ChipDeviceEventHandler::Handle() event kCommissioningComplete");
HandleCommissioningComplete(event, arg, runPostCommissioning, targetNodeId, targetFabricIndex);
}

0 comments on commit cf9f463

Please sign in to comment.