da_revocation: fix serial number formatting in revocation set generat… (

#37104)

* da_revocation: fix serial number formatting in revocation set generation script

Also update test data to ensure 2-byte alignment

* add comment explaining the change

* update comment

credentials/generate_revocation_set.py

@@ -240,7 +240,13 @@ def generate_revocation_set_from_crl(crl_file: x509.CertificateRevocationList,
         except Exception:
             pass
 
-        serialnumber_list.append(bytes(str('{:02X}'.format(revoked_cert.serial_number)), 'utf-8').decode('utf-8'))
+        # Ensure the serial number is always a 2-byte aligned hex string.
+        # TestDACRevocationDelegateImpl encodes the serial number as an even-length hex string
+        # using BytesToHex in src/lib/support/BytesToHex.cpp.
+        # As the primary consumer of this data, we should use the same here.
+        serialnumber = '{:02X}'.format(revoked_cert.serial_number)
+        serialnumber = serialnumber if len(serialnumber) % 2 == 0 else '0' + serialnumber
+        serialnumber_list.append(serialnumber)
 
     entry = {
         "type": "revocation_set",

credentials/test/revoked-attestation-certificates/revocation-sets/revocation-set-for-pai.json

@@ -4,7 +4,7 @@
         "issuer_subject_key_id": "63540E47F64B1C38D13884A462D16C195D8FFB3C",
         "issuer_name": "MD0xJTAjBgNVBAMMHE1hdHRlciBEZXYgUEFJIDB4RkZGMSBubyBQSUQxFDASBgorBgEEAYKifAIBDARGRkYx",
         "revoked_serial_numbers": [
-            "AB042494323FE54",
+            "0AB042494323FE54",
             "19367D978EAC533A",
             "2569383D24BB36EA"
         ],