Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
ksperling-apple and bzbarsky-apple committed Dec 23, 2024
1 parent f11f465 commit a355e9f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/MTRCommissioningParameters.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ MTR_AVAILABLE(ios(16.1), macos(13.0), watchos(9.1), tvos(16.1))
* Read device type information from all endpoints during commissioning.
* Defaults to NO.
*/
@property (nonatomic, assign) BOOL readEndpointInformation;
@property (nonatomic, assign) BOOL readEndpointInformation MTR_NEWLY_AVAILABLE;

@end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ - (MTREndpointInfo *)rootEndpoint
{
MTRDeviceController * strongController = mController;
id<MTRDeviceControllerDelegate> strongDelegate = mDelegate;
VerifyOrReturn(strongDelegate && mQueue);
VerifyOrReturn(strongDelegate && mQueue && strongController);

// TODO: These checks are pointless since currently mController == mDelegate
BOOL wantCommissioneeInfo = [strongDelegate respondsToSelector:@selector(controller:readCommissioneeInfo:)];
Expand Down
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/MTREndpointInfo.mm
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ + (BOOL)populateChildrenForEndpoints:(NSDictionary<NSNumber *, MTREndpointInfo *
}

// Now iterate over the endpoints in reverse topological order, i.e. bottom up. This means
// that we will visit children before parents, so the first time we see and endpoint in a
// that we will visit children before parents, so the first time we see an endpoint in a
// PartsList we can assign it as a child of the endpoint we're processing, and we can be sure
// that this is the closest parent, not some higher ancestor using the Full-Family Pattern.
NSMutableArray<MTREndpointInfo *> * children = [[NSMutableArray alloc] init];
Expand Down

0 comments on commit a355e9f

Please sign in to comment.