Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python tests error handling #43

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Fix python tests error handling #43

merged 4 commits into from
Dec 14, 2023

Conversation

ccruzagralopes
Copy link
Contributor

@ccruzagralopes ccruzagralopes commented Dec 12, 2023 •
edited
Loading

What changed

  • Started raising an exception if the commissioning fails in the test suite setup.
  • Fixed the steps state after a failure happens during a python test. After the failure the test skips most of the following steps and then executes the last one, to show the logs.

Testing

  • Commissioning error is reported and cancels the test suite execution.
Screenshot 2023-12-12 at 15 23 25
  • Test case steps' states after a failure.
Screenshot 2023-12-12 at 15 14 48 Screenshot 2023-12-12 at 15 14 57
  • Test case that doesn't follow the template with errors on multiple tests
Screenshot 2023-12-13 at 08 23 05

@ccruzagralopes ccruzagralopes self-assigned this Dec 12, 2023
@ccruzagralopes ccruzagralopes marked this pull request as draft December 12, 2023 19:24
@ccruzagralopes
Copy link
Contributor Author

Converted the PR to draft because I found a bug

@ccruzagralopes ccruzagralopes marked this pull request as ready for review December 13, 2023 13:06
@ccruzagralopes
Copy link
Contributor Author

The bug was fixed

@ccruzagralopes ccruzagralopes merged commit 100ec49 into project-chip:main Dec 14, 2023
8 checks passed
@ccruzagralopes ccruzagralopes deleted the fix_python_tests_error_handling branch December 14, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiltonlima hiltonlima hiltonlima approved these changes

@antonio-amjr antonio-amjr antonio-amjr approved these changes

@rquidute rquidute rquidute approved these changes

@fabiowmm fabiowmm Awaiting requested review from fabiowmm

@mikaelhm mikaelhm Awaiting requested review from mikaelhm

Assignees

@ccruzagralopes ccruzagralopes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccruzagralopes @mikaelhm @rquidute @antonio-amjr @hiltonlima