Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt request refactor #31

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Prompt request refactor #31

merged 4 commits into from
Nov 22, 2023

Conversation

hiltonlima
Copy link
Contributor

@hiltonlima hiltonlima commented Nov 21, 2023

Issue: [Bug] The submit button is not appearing #60

Description

  • Proposal to add a new value for file uploads
  • It needs to be aligned with the Frontend, as the new type will only work after updating the Frontend.

Changes

  • Create a new Enum value for file upload request
  • Prompt type refactor

Frontend PR counterpart: Missing submit button #15

@raul-marquez-csa raul-marquez-csa merged commit fbae043 into project-chip:v1.3-TE1 Nov 22, 2023
8 checks passed
@hiltonlima hiltonlima deleted the prompt_request_refactor branch November 23, 2023 12:49
ccruzagralopes added a commit that referenced this pull request Nov 29, 2023
* Fix prblem with sdk_tests collection using hardcoded paths

* Enable github workflows for main branch (#17)

* Enable github workflows for main branch

* Ignore Dockerfile

* mypy: ignore python_testing in sdk_collection

* minor linting issues fixed

* ignore .devcontainer in spell checker

* move .env file back in root

* Update reference to fetch_sdk_tests_and_runner.sh

* Use `pull_request_target` event to support forks

* Update yaml_test_folder.py (#21)

* Update yaml_test_folder.py

* Update test_sdk_yaml_collection.py

* Update unittests.yml

Don't run old code for unit tests

* [Fix] remove TestRunConfig usage from TH Backend (#581) (#6)

* Add the repeat endpoint, deprecate the test_run_config endpoints and

force the test run execution creation to use selected tests, and not test_run_config_id.

* Deprecating unit tests related with
test_run_config, creating new endpoint with required selected_tests
parameter and ignoring the test_run_config reference, renaming the
repeat endpoint method and adding comments.

* Updating select_tests logic, moving to a utils
file, and adding unit test for the repeat endpoint

* Updating comments and adding missing attribution to
None for test_run_config_id

* Adding missing TODO comment.

* Fixing selected_tests logic

* Updating the 'repeat' unit test to use more
suites to cover more cases.

* Removing "/new" endpoint, updating logic of the
default test run execution endpoint and updating unit tests, "repeat"
endpoint and utils

* Adding the new DB column "collection_id" to the
TestSuiteExecution table. A DB revision file was created and the code
was refactored to use this new info.

* Removing unnecessary import

* Set default log level to info, to eliminate chatter from python runner (#23)

* Update SDK SHA (#25)

* Added support to reset db for test (#28)

* Missing submit button (#30)

* Updates MessageTypeEnum to include options and message types

* Update app/user_prompt_support/user_prompt_manager.py

Co-authored-by: antonio-amjr <[email protected]>

* Update app/constants/websockets_constants.py

Co-authored-by: hiltonlima <[email protected]>

* Update app/user_prompt_support/user_prompt_manager.py

---------

Co-authored-by: Romulo Quidute Filho <[email protected]>
Co-authored-by: antonio-amjr <[email protected]>
Co-authored-by: hiltonlima <[email protected]>
Co-authored-by: Carolina Lopes <[email protected]>

* Update version

* Prompt request refactor (#31)

* Refactor to use only 1 enum

* Removed unsed import

* Fix isort

* Adds a new Message prompt request

---------

Co-authored-by: raul-marquez-csa <[email protected]>

* update backend version in FE (#32)

* update backend version in FE

* Update .version_information

* Update .version_information

* change ssh to https (#33)

* Undo version information update

---------

Co-authored-by: Mikael H. Moeller <[email protected]>
Co-authored-by: Mikael Møller <[email protected]>
Co-authored-by: antonio-amjr <[email protected]>
Co-authored-by: Romulo Quidute Filho <[email protected]>
Co-authored-by: Raul Marquez <[email protected]>
Co-authored-by: hiltonlima <[email protected]>
Co-authored-by: raul-marquez-csa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants