-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing submit button #30
Merged
rquidute
merged 4 commits into
project-chip:main
from
raul-marquez-csa:missing-submit-button
Nov 17, 2023
Merged
Missing submit button #30
rquidute
merged 4 commits into
project-chip:main
from
raul-marquez-csa:missing-submit-button
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-marquez-csa
requested review from
mikaelhm,
raju-apple,
fabiowmm,
ccruzagralopes,
antonio-amjr,
gladystonfranca and
gvargas-csa
November 16, 2023 19:27
antonio-amjr
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change pointed by the GitHub checking:
hiltonlima
approved these changes
Nov 17, 2023
Co-authored-by: antonio-amjr <[email protected]>
Co-authored-by: hiltonlima <[email protected]>
rquidute
approved these changes
Nov 17, 2023
antonio-amjr
approved these changes
Nov 17, 2023
ccruzagralopes
added a commit
that referenced
this pull request
Nov 17, 2023
* Updates MessageTypeEnum to include options and message types * Update app/user_prompt_support/user_prompt_manager.py Co-authored-by: antonio-amjr <[email protected]> * Update app/constants/websockets_constants.py Co-authored-by: hiltonlima <[email protected]> * Update app/user_prompt_support/user_prompt_manager.py --------- Co-authored-by: Romulo Quidute Filho <[email protected]> Co-authored-by: antonio-amjr <[email protected]> Co-authored-by: hiltonlima <[email protected]> Co-authored-by: Carolina Lopes <[email protected]>
ccruzagralopes
added a commit
that referenced
this pull request
Nov 29, 2023
* Fix prblem with sdk_tests collection using hardcoded paths * Enable github workflows for main branch (#17) * Enable github workflows for main branch * Ignore Dockerfile * mypy: ignore python_testing in sdk_collection * minor linting issues fixed * ignore .devcontainer in spell checker * move .env file back in root * Update reference to fetch_sdk_tests_and_runner.sh * Use `pull_request_target` event to support forks * Update yaml_test_folder.py (#21) * Update yaml_test_folder.py * Update test_sdk_yaml_collection.py * Update unittests.yml Don't run old code for unit tests * [Fix] remove TestRunConfig usage from TH Backend (#581) (#6) * Add the repeat endpoint, deprecate the test_run_config endpoints and force the test run execution creation to use selected tests, and not test_run_config_id. * Deprecating unit tests related with test_run_config, creating new endpoint with required selected_tests parameter and ignoring the test_run_config reference, renaming the repeat endpoint method and adding comments. * Updating select_tests logic, moving to a utils file, and adding unit test for the repeat endpoint * Updating comments and adding missing attribution to None for test_run_config_id * Adding missing TODO comment. * Fixing selected_tests logic * Updating the 'repeat' unit test to use more suites to cover more cases. * Removing "/new" endpoint, updating logic of the default test run execution endpoint and updating unit tests, "repeat" endpoint and utils * Adding the new DB column "collection_id" to the TestSuiteExecution table. A DB revision file was created and the code was refactored to use this new info. * Removing unnecessary import * Set default log level to info, to eliminate chatter from python runner (#23) * Update SDK SHA (#25) * Added support to reset db for test (#28) * Missing submit button (#30) * Updates MessageTypeEnum to include options and message types * Update app/user_prompt_support/user_prompt_manager.py Co-authored-by: antonio-amjr <[email protected]> * Update app/constants/websockets_constants.py Co-authored-by: hiltonlima <[email protected]> * Update app/user_prompt_support/user_prompt_manager.py --------- Co-authored-by: Romulo Quidute Filho <[email protected]> Co-authored-by: antonio-amjr <[email protected]> Co-authored-by: hiltonlima <[email protected]> Co-authored-by: Carolina Lopes <[email protected]> * Update version * Prompt request refactor (#31) * Refactor to use only 1 enum * Removed unsed import * Fix isort * Adds a new Message prompt request --------- Co-authored-by: raul-marquez-csa <[email protected]> * update backend version in FE (#32) * update backend version in FE * Update .version_information * Update .version_information * change ssh to https (#33) * Undo version information update --------- Co-authored-by: Mikael H. Moeller <[email protected]> Co-authored-by: Mikael Møller <[email protected]> Co-authored-by: antonio-amjr <[email protected]> Co-authored-by: Romulo Quidute Filho <[email protected]> Co-authored-by: Raul Marquez <[email protected]> Co-authored-by: hiltonlima <[email protected]> Co-authored-by: raul-marquez-csa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: [Bug] The submit button is not appearing #60
Frontend PR: Missing submit button #14
Missing submit button fixed, see frontend PR description for testing results.