Enforced exit code 0 in prestart.sh #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the problem below, by ensuring that
prestart.sh
return a zero exit code on successful completion.Problem:
prestart.sh
will attempt to runtest_collection/<collection_name>/prestart.sh
if that script exists.This is done by:
However, if the script doesn't exist.
[ -x $prestart ]
will return a non-zero value.As this is the last step in
prestart.sh
the exit code ofprestart.sh
will be the non-zero value if the last iteration in the for-loop is for a test_collection that doesn't have a prestart script.This will stop the start.sh to not start the
gunicorn
server.