[Redesign/Refactoring] Move chiptool-specific code under test_collections #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccruzagralopes
changed the title
ccruzagralopes
force-pushed
the
85_Move-chiptool-specific-code-under-test_collections
branch
from
69379a1 to
42f0b02
Compare
ccruzagralopes
requested review from
mikaelhm,
rquidute,
fabiowmm,
antonio-amjr,
hiltonlima and
gladystonfranca
mikaelhm
requested changes
Nov 14, 2023
test_collections/tool_blocklist_unit_tests/test_suite_blocklist_1/suite.py
Outdated
Show resolved
Hide resolved
test_collections/tool_blocklist_unit_tests/test_suite_blocklist_2/suite.py
Outdated
Show resolved
Hide resolved
test_collections/tool_unit_tests/test_suite_chip_tool/test_suite_chip_tool.py
Outdated
Show resolved
Hide resolved
antonio-amjr
approved these changes
Nov 27, 2023
rquidute
approved these changes
Nov 28, 2023
hiltonlima
approved these changes
Nov 28, 2023
mikaelhm
approved these changes
Dec 4, 2023
ccruzagralopes
deleted the
85_Move-chiptool-specific-code-under-test_collections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Moved chip-tool specific code under
test_collectionsRelated issue
Dependency
Must be merged after the submodule PR and after updating its SHA:
Testing
All unit tests passed
I ran some test cases in TH UI and they worked as expected
I also ran a manual and a python test, but since the Submit button is not showing, I couldn't complete them