Standardize the use of a prestart.sh script inside Test Collections
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-amjr
approved these changes
Nov 9, 2023
ccruzagralopes
approved these changes
Nov 9, 2023
mikaelhm
force-pushed
the
feature/test_collection_prestart
branch
from
a79e23d to
e97a366
Compare
rquidute
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be seeing more test collection in the future. Some of these might need to perform some actions before starting the test harness.
An example of this is how the
sdk_teststoday rely on a script to fetch latest yaml and python runner form SDK repo.This PR standardized this, by automatically looking for a
prestart.shscript inside the test collection folder.