Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python tests model classes #19

Conversation

rquidute
Copy link
Contributor

@rquidute rquidute commented Nov 8, 2023

What changed

This PR is the phase-3 for the feature Python tests in TH UI.
This goal of this PR is to add the model classes related to Python Tests.

We need feedback if we need to move toward having a common model classes and yaml and python model classes inherit from that or we may keep using the way this PR is implemented by having yaml and python tests having it own attributes and methods.

Related Issue

Python tests in TH UI - Phase 3 (Add Python Test model classes) - project-chip/certification-tool#74

Testing

  • Unit test added and passing
Screenshot 2023-11-08 at 13 54 45
  • YAML test execution keep running successfully
Screenshot 2023-11-08 at 14 04 10
  • New Python Test Collection SDK Python Test is displayed in UI (For development purpose I changed the TC_ACE_1_3 by adding the required methods in other to display this test case in UI)
Screenshot 2023-11-08 at 09 55 25
  • Python Test steps are displayed in UI (They are shown as failed in the screenshot since the runner is under implementation, the goal of this PR is just to present the Test Case and list the steps.)
Screenshot 2023-11-08 at 14 12 26

@mikaelhm mikaelhm closed this Nov 8, 2023
@mikaelhm mikaelhm reopened this Nov 8, 2023
@mikaelhm
Copy link
Contributor

mikaelhm commented Nov 8, 2023

I just tried to close/reopen to get the GitHub workflow to run unittests

@mikaelhm
Copy link
Contributor

mikaelhm commented Nov 8, 2023

If you rebase on main I think your PR should pass the checks.

@rquidute rquidute requested a review from mikaelhm December 6, 2023 18:07
app/chip_tool/chip_tool.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants