Add support for configuring terms and conditions in device commissioning #173
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `enhanced_setup_flow` configuration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite. Key changes include: - Added the `EnhancedSetupFlowConfig` class to `DutConfig`, which allows specifying the T&C version and user response required during commissioning. - Updated `generate_command_arguments` in `utils.py` to append the necessary arguments for T&C validation and the device's commissioning method. - Adjusted model validation to ensure the `enhanced_setup_flow` field is processed correctly within `DutConfig`. These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation.
rquidute
requested changes
Dec 17, 2024
test_collections/matter/sdk_tests/support/performance_tests/utils.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/__init__.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
|
Hi @swan-amazon I changed the target from |
Co-authored-by: Romulo Quidute Filho <[email protected]>
Hey @rquidute , I'm not sure why those spell checks weren't failing previously. I didn't add the words that it's flagging on now... I was asking Raju but he didn't know. I asked if something was recently enabled and he doesn't think so. What should we do? |
Co-authored-by: Romulo Quidute Filho <[email protected]>
…ils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…s/utils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…s/utils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…t__.py Co-authored-by: Romulo Quidute Filho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
enhanced_setup_flowconfiguration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite.Key changes include:
EnhancedSetupFlowConfigclass toDutConfig, which allows specifying the T&C version and user response required during commissioning.generate_command_argumentsinutils.pyto append the necessary arguments for T&C validation and the device's commissioning method.enhanced_setup_flowfield is processed correctly withinDutConfig.These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation.