Feature/446 add checking when no pics is informed #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquidute
requested review from
ccruzagralopes,
fabiowmm,
antonio-amjr,
hiltonlima and
gladystonfranca
rquidute
changed the title
ccruzagralopes
approved these changes
Oct 22, 2024
antonio-amjr
approved these changes
Oct 23, 2024
hiltonlima
approved these changes
Oct 23, 2024
rquidute
commented
Oct 23, 2024
* Reverting the BR_VARIANT option to the otbr start script * Adding TODO to the script * Adding missing comment char * Updating Script Comment Year Co-authored-by: Romulo Quidute Filho <[email protected]> * Adding switch parameters options to the script --------- Co-authored-by: Romulo Quidute Filho <[email protected]>
* replace erro with warning * Update test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py Co-authored-by: Carolina Lopes <[email protected]> * black error fix * pr review --------- Co-authored-by: Carolina Lopes <[email protected]>
* Fixing intermittent problem with Python's Base Manager Creating the manager now only once in the SDK Container Init * Refactoring and updating the unit tests with related mocks
hiltonlima
force-pushed
the
spring2025
branch
from
4f87387 to
316a934
Compare
hiltonlima
force-pushed
the
feature/446_add_checking_no_pics_informed
branch
from
37daaa1 to
05bc1d3
Compare
hiltonlima
force-pushed
the
spring2025
branch
from
ad73477 to
0bb4f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
What Changed
Added checking for PICS informed before starting a test run
Important: DO NOT MERGE - Wainting for frontend implementation.Frontend issue: project-chip/certification-tool#469
Related Issue
project-chip/certification-tool#446
Testing
Development testing: backend returns error code 422. Frontend still not handling.
New unit tests passing
