[FIX] Reverting the OTBR Start Script #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-amjr
requested review from
rquidute,
fabiowmm,
ccruzagralopes,
hiltonlima and
gladystonfranca
rquidute
approved these changes
Sep 26, 2024
ccruzagralopes
approved these changes
Sep 26, 2024
Co-authored-by: Romulo Quidute Filho <[email protected]>
hiltonlima
approved these changes
Sep 26, 2024
|
@antonio-amjr could you rebase/target to |
rquidute
approved these changes
Sep 26, 2024
Done @hiltonlima |
hiltonlima
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Reverting the BR_VARIANT option to the otbr start script * Adding TODO to the script * Adding missing comment char * Updating Script Comment Year Co-authored-by: Romulo Quidute Filho <[email protected]> * Adding switch parameters options to the script --------- Co-authored-by: Romulo Quidute Filho <[email protected]>
hiltonlima
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Reverting the BR_VARIANT option to the otbr start script * Adding TODO to the script * Adding missing comment char * Updating Script Comment Year Co-authored-by: Romulo Quidute Filho <[email protected]> * Adding switch parameters options to the script --------- Co-authored-by: Romulo Quidute Filho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: project-chip/certification-tool#420
Reverting the OTBR start script to use variables.
It seems important for environments with multiples Thread networks that we could easily change the Thread parameters.
So we're reverting the script to use the BR_VARIANT once again so the main thread fields may be changed all at once.
Some comments and a step to stop an already running container will be kept.