Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Force container removal at destroy #143

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

rquidute
Copy link
Contributor

@rquidute rquidute commented Sep 11, 2024

What changed

Added force remove and after container be destroyed.

Related issue

project-chip/certification-tool#414

Testing

Unit test passing, and the TC-DRLK-2.1 is now passing
Screenshot 2024-09-11 at 18 45 39

@rquidute rquidute marked this pull request as ready for review September 13, 2024 17:54
Copy link
Contributor

@fabiowmm fabiowmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the except catches the timeout, I'm ok with this.

@rquidute rquidute changed the base branch from main to v2.11-beta3.1+fall2024 September 16, 2024 20:47
@rquidute rquidute merged commit 5d454ab into v2.11-beta3.1+fall2024 Sep 16, 2024
8 checks passed
hiltonlima added a commit that referenced this pull request Sep 19, 2024
…ython_tests

* v2.11-beta3.1+fall2024:
  Fix data_model mapped volume
  [FIX] Force container removal at destroy (#143)
  [FIX] Handle Python test execution runtime errors (#145)

# Conflicts:
#	test_collections/matter/sdk_tests/support/python_testing/models/test_case.py
hiltonlima added a commit that referenced this pull request Sep 26, 2024
* [FIX] Handle Python test execution runtime errors (#145)

* Handle Python test execution runtime errors

* Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py

Co-authored-by: hiltonlima <[email protected]>

---------

Co-authored-by: hiltonlima <[email protected]>

* [FIX] Force container removal at destroy (#143)

* Force container removal

* Remove __wait_for_server_exit

* Surround __wait_for_server_exit with try except

* Fix mypy

* Fix data_model mapped volume

* Update test_collections/matter/sdk_tests/support/sdk_container.py

Co-authored-by: Romulo Quidute Filho <[email protected]>

---------

Co-authored-by: Romulo Quidute Filho <[email protected]>
Co-authored-by: Romulo Quidute Filho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants