-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Force container removal at destroy #143
Merged
rquidute
merged 4 commits into
v2.11-beta3.1+fall2024
from
fix/414_force_remove_container
Sep 16, 2024
Merged
[FIX] Force container removal at destroy #143
rquidute
merged 4 commits into
v2.11-beta3.1+fall2024
from
fix/414_force_remove_container
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquidute
requested review from
fabiowmm,
antonio-amjr,
hiltonlima and
gladystonfranca
September 11, 2024 22:30
ccruzagralopes
approved these changes
Sep 12, 2024
antonio-amjr
approved these changes
Sep 12, 2024
gladystonfranca
approved these changes
Sep 12, 2024
hiltonlima
approved these changes
Sep 13, 2024
fabiowmm
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the except catches the timeout, I'm ok with this.
hiltonlima
added a commit
that referenced
this pull request
Sep 26, 2024
* [FIX] Handle Python test execution runtime errors (#145) * Handle Python test execution runtime errors * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: hiltonlima <[email protected]> --------- Co-authored-by: hiltonlima <[email protected]> * [FIX] Force container removal at destroy (#143) * Force container removal * Remove __wait_for_server_exit * Surround __wait_for_server_exit with try except * Fix mypy * Fix data_model mapped volume * Update test_collections/matter/sdk_tests/support/sdk_container.py Co-authored-by: Romulo Quidute Filho <[email protected]> --------- Co-authored-by: Romulo Quidute Filho <[email protected]> Co-authored-by: Romulo Quidute Filho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Added force remove and after container be destroyed.
Related issue
project-chip/certification-tool#414
Testing
Unit test passing, and the TC-DRLK-2.1 is now passing