Fix decommissioning problem for simulated test cases #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccruzagralopes
requested review from
rquidute,
fabiowmm,
antonio-amjr,
hiltonlima and
gladystonfranca
antonio-amjr
approved these changes
Oct 31, 2023
mikaelhm
approved these changes
Oct 31, 2023
hiltonlima
approved these changes
Oct 31, 2023
ccruzagralopes
deleted the
40-not_able_to_perform_decommissioning_in_simulated_test_case
branch
hiltonlima
added a commit
that referenced
this pull request
Jan 29, 2024
Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the following issue:
Maybe a permanent solution should involve changes in the runner so that it doesn't stop automatically at every test run. In that case we wouldn't need to start and stop it every time we need to commission or decommission a device, we'd start it at the beginning of a test suite execution and stop it at the cleanup.
Since changes in the runner usually takes longer, we can have this temporary solution for TH now and then migrate to another solution involving the runner changes later.