Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop cloning data model directory #112

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

ccruzagralopes
Copy link
Contributor

The data model directory is already present in the SDK image, there's no need to clone it locally anymore.

I tested running test cases that need the data model XML files and they passed:
Screenshot 2024-07-24 at 11 07 06

@ccruzagralopes
Copy link
Contributor Author

Should be merged after project-chip/connectedhomeip#34481 goes in

@ccruzagralopes
Copy link
Contributor Author

The SDK PR has been merged

@ccruzagralopes ccruzagralopes requested a review from fabiowmm August 8, 2024 13:09
@hiltonlima hiltonlima requested a review from rquidute August 15, 2024 12:15
@hiltonlima hiltonlima merged commit 89f37b6 into main Aug 15, 2024
8 checks passed
@hiltonlima hiltonlima deleted the stop-cloning-data-model-directory branch August 15, 2024 20:25
hiltonlima added a commit that referenced this pull request Aug 15, 2024
* main:
  Stop cloning data model directory (#112)
  Python test scripts validator (#128)
  v2.11-beta2+fall2024 (#121)
  Address the location change of the otbr scripts (#127)
  Use manual-code or discriminator and password, never all of them (#125)
  Fix python test steps handling (#124)
  PICS v2 support (#122)
  support wifipaf-wifi command for test harness (#117)
  Reverting workaround due to log being truncated as sdk already fix the problem. (#120)
  Remove 22.04 packages versions (#119)

# Conflicts:
#	test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py
#	test_collections/matter/sdk_tests/support/python_testing/models/test_case.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker has to be updated by adding the data model directory
4 participants