Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatically disable it in production builds #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: automatically disable it in production builds #8

wants to merge 1 commit into from
+78 −15

Conversation

cabelitos
Copy link

This commit reduces the burden for the developer to remove the HOC, before going to PROD. Having this in mind, it uses the same approach as the prop-types library, where checks are completely disabled.

Progress

  • Done;

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

yarn test

@cabelitos
feat: automatically disable it in production builds
8e5b651 
This commit reduces the burden for the developer to remove the HOC, before
going to PROD. Having this in mind, it uses the same approach as the
prop-types library, wher checks are completely disabled.
@cabelitos cabelitos requested a review from barbieri May 12, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbieri barbieri Awaiting requested review from barbieri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cabelitos